Handle entity escaping later in received messages. #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
japsu
approved these changes
Sep 27, 2016
ekmartin
requested changes
Sep 27, 2016
| @@ -282,6 +282,13 @@ describe('Bot', function () { | |||
| this.bot.parseText('<!somecommand> <!somecommand|readable>') | |||
| .should.equal('<somecommand> <readable>'); | |||
| }); | |||
| it('should handle entity-encoded messages from slack', function () { | |||
There was a problem hiding this comment.
woop, this should have a newline before it :D
would you mind adding an explicit assertion that makes sure this doesn't happen anymore as well?
There was a problem hiding this comment.
sure, i'll add newline. originally left that away to kinda tie that together with previous test.
|
Thanks! |
- Move entity decoding to be last replace operation to avoid limited value injection and denial of service. - Re-arrange entity decoding to avoid them chain-decoding: amp must be decoded last as ampersand is included in lt and gt matches. - Add test-cases for escaped messages.
jlaunonen
force-pushed
the
entities-handling
branch
from
485488d
to
10eb303
Compare
|
Published in version 3.8.5 😄 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
value injection and denial of service.
decoded last as ampersand is included in lt and gt matches.