Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support aws2 as kubeconfig authenticator #2338

Closed
wants to merge 1 commit into from
Closed

Support aws2 as kubeconfig authenticator #2338

wants to merge 1 commit into from

Conversation

michaelbeaumont
Copy link
Contributor

Description

I see conflicting information on whether aws v2 is supposed to be named aws or aws2 but seems some users definitely only have aws2 available. So I think adding this makes sense.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@michaelbeaumont
Copy link
Contributor Author

michaelbeaumont commented Jun 17, 2020 •
edited
Loading

Hmm reconsidering this see #1562 (comment)

@michaelbeaumont michaelbeaumont deleted the awscli2-auth branch June 17, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 Awaiting requested review from cPu1

@martina-if martina-if Awaiting requested review from martina-if

Assignees
No one assigned
Labels
area/general-cli kind/bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@michaelbeaumont