-
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open_basedir /.dockerenv problem #5
Comments
Yes I realized that too some time ago, I used another approach: Did you use this version (meaning this fix didn't work)? |
I pulled elabftw/elabimg:latest which is 4 weeks old. Has you fix been published yet? As it is part of the master branch and tagged with a version I would assume so, right? |
I think if you build it yourself you'll get the fix but the one from docker hub might not have it. |
I just built the dev branch myself and are still reproducing the issue:
I checked the commit history: Your fix has been merged to the dev branch but seems not to work (perhaps .dockerenv is being created during another step?). When testing with a docker image with the fixed open_basedir path it's working. |
Ok I'll merge your change then. You can even add a commit on your PR to remove the rm .dockerenv from the Dockerfile ;) |
Removed 'rm .Dockerfile' as it is now covered by open_basedir declaration
@NicolasCARPi Sure, I updated the branch with your suggestion |
@NicolasCARPi Sorry, I got confused with the branches. My commit was not on the patch-2 branch but on the dev branch in my fork. Is it possible that my pull request needs to be set to the dev branch, too? Right now it's for hypernext. I will push the change to the patch-2 branch now. |
* hypernext: Review tasks from #5 Fix missing .dockerenv entry in open_basedir
* hypernext: add --prefer-dist --no-progress --no-suggest to composer install command Review tasks from #5 add delete method Fix missing .dockerenv entry in open_basedir add gzip compression for javascript and css changelog for 1.4.0 improve disable_function sed add php7-exif
* hypernext: add --prefer-dist --no-progress --no-suggest to composer install command Review tasks from #5 add delete method Fix missing .dockerenv entry in open_basedir add gzip compression for javascript and css changelog for 1.4.0 improve disable_function sed add php7-exif
* hypernext: add --prefer-dist --no-progress --no-suggest to composer install command Review tasks from #5 add delete method Fix missing .dockerenv entry in open_basedir add gzip compression for javascript and css changelog for 1.4.0 improve disable_function sed add php7-exif
When trying to get my dev environment up and running again an error occured when running
docker exec -it elabftw composer install
:Adding
/.dockerenv
to the open_basedir path in php.ini seems to fix it.The text was updated successfully, but these errors were encountered: