Big project cleanup (use Typescript, move files around, update stuff, remove unused code, ...)

.eslintrc.json

@@ -9,6 +9,7 @@
     "react/no-unknown-property": ["error", { "ignore": ["sx"] }],
     "no-unused-expressions": "off",
     "@babel/no-unused-expressions": "warn",
+    "quotes": ["warn", "single", { "avoidEscape": true }],
 
     "arrow-parens": ["error", "as-needed"],
     "arrow-spacing": "error",

.github/workflows/ci.yml

@@ -4,21 +4,23 @@ on: [pull_request, push]
 
 jobs:
   main:
+    # We don't build PRs from dependabot, as we run everything for its branch push anyway
+    if: github.actor != 'dependabot[bot]' || github.event_name == 'push'
     runs-on: ubuntu-latest
     steps:
     - uses: actions/checkout@v3
     - uses: actions/setup-node@v3
       with:
         node-version: 16
     - run: npm ci
+    - run: npx eslint src --max-warnings=0
     - run: npm run build
     - run: npm test
 
 
     # Prepare test deployment
     - name: Build for test deployment
       env:
-        REACT_APP_ENABLE_SENTRY: 1
         REACT_APP_INCLUDE_LEGAL_NOTICES: 1
       run: |
         builddate="$(date --utc '+%Y-%m-%d_%H-%M-%S')"
@@ -36,29 +38,28 @@ jobs:
         PUBLIC_URL=${deploydir} npm run build
 
     - name: Archive test deployment files as artifact
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: test-deployment-files
         path: |
           build
-          .deploy-settings.toml
+          .github/.deploy-settings.toml
           deploydir.tmp
 
     # Prepare production deployment
     - name: Build for prod deployment
       if: github.repository_owner == 'elan-ev' && github.ref == 'refs/heads/master'
       env:
-        REACT_APP_ENABLE_SENTRY: 1
         REACT_APP_INCLUDE_LEGAL_NOTICES: 1
       run: |
         rm -rf build
         PUBLIC_URL="/" npm run build
 
     - name: Archive prod deployment files as artifact
       if: github.repository_owner == 'elan-ev' && github.ref == 'refs/heads/master'
-      uses: actions/upload-artifact@v2
+      uses: actions/upload-artifact@v3
       with:
         name: prod-deployment-files
         path: |
           build
-          .deploy-settings.toml
+          .github/.deploy-settings.toml

.github/workflows/deploy-prod.yml

@@ -34,17 +34,17 @@ jobs:
     # Unfortunately we cannot use `actions/download-artifact` here since that
     # only allows to download artifacts from the same run.
     - name: Download artifacts from build workflow
-      uses: actions/github-script@v3.1.0
+      uses: actions/github-script@v6
       with:
         script: |
-          const artifacts = await github.actions.listWorkflowRunArtifacts({
+          const artifacts = await github.rest.actions.listWorkflowRunArtifacts({
               owner: context.repo.owner,
               repo: context.repo.repo,
               run_id: ${{ github.event.workflow_run.id }},
           });
           const deployFiles = artifacts.data.artifacts
               .filter(a => a.name == "prod-deployment-files")[0];
-          const download = await github.actions.downloadArtifact({
+          const download = await github.rest.actions.downloadArtifact({
               owner: context.repo.owner,
               repo: context.repo.repo,
               artifact_id: deployFiles.id,
@@ -55,7 +55,7 @@ jobs:
           fs.writeFileSync('${{github.workspace}}/artifacts.zip', Buffer.from(download.data));
 
           // The artifact is not needed anymore
-          github.actions.deleteArtifact({
+          github.rest.actions.deleteArtifact({
               owner: context.repo.owner,
               repo: context.repo.repo,
               artifact_id: deployFiles.id,
@@ -66,7 +66,7 @@ jobs:
 
     - name: Prepare deployment files
       run: |
-        mv .deploy-settings.toml settings.toml
+        mv .github/.deploy-settings.toml settings.toml
         mv build/* .
         rmdir build
 

.github/workflows/deploy-test.yml

@@ -21,17 +21,17 @@ jobs:
     # Unfortunately we cannot use `actions/download-artifact` here since that
     # only allows to download artifacts from the same run.
     - name: Download artifacts from build workflow
-      uses: actions/github-script@v3.1.0
+      uses: actions/github-script@v6
       with:
         script: |
-          const artifacts = await github.actions.listWorkflowRunArtifacts({
+          const artifacts = await github.rest.actions.listWorkflowRunArtifacts({
               owner: context.repo.owner,
               repo: context.repo.repo,
               run_id: ${{ github.event.workflow_run.id }},
           });
           const deployFiles = artifacts.data.artifacts
               .filter(a => a.name == "test-deployment-files")[0];
-          const download = await github.actions.downloadArtifact({
+          const download = await github.rest.actions.downloadArtifact({
               owner: context.repo.owner,
               repo: context.repo.repo,
               artifact_id: deployFiles.id,
@@ -42,7 +42,7 @@ jobs:
           fs.writeFileSync('${{github.workspace}}/artifacts.zip', Buffer.from(download.data));
 
           // The artifact is not needed anymore
-          github.actions.deleteArtifact({
+          github.rest.actions.deleteArtifact({
               owner: context.repo.owner,
               repo: context.repo.repo,
               artifact_id: deployFiles.id,

README.md

@@ -20,8 +20,8 @@ Opencast instance.
 Opencast Studio uses somewhat new web technologies that are not yet (fully) supported by all browsers.
 The following table depicts the current state of browser support (as of May 2022).
 
-|            | Firefox ≥ 68   | Chrome ≥ 77    | Edge ≥ 79      | Safari ≥ 14 |
-| ---------- | -------------- | -------------- | -------------- | ----------- |
+|            | Firefox ≥ 68   | Chrome ≥ 77    | Edge ≥ 79      | Safari ≥ 14.1 |
+| ---------- | -------------- | -------------- | -------------- | ------------- |
 | Windows 11 | ✔              | ✔              | ✔              | -
 | Windows 10 | ✔              | ✔              | ✔              | -
 | Linux      | ✔              | ✔              | ✔              | -
@@ -144,27 +144,3 @@ npm run build
 | `PUBLIC_URL`                      | `/studio`          | Path from which Studio will be served
 | `REACT_APP_SETTINGS_PATH`         | `/mysettings.toml` | Path from which to load the configuration (see `CONFIGURATION.md` for more information)
 | `REACT_APP_INCLUDE_LEGAL_NOTICES` | `1`                | Set to `1` to include legal notices and information about ELAN e.V., any other value or having this variable not set will not include them. Unless you are working for ELAN e.V. there is probably no reason for you to use this variable.
-
-
-## How to release Opencast Studio
-
-Checkout the branch `master` from Opencast Studio and make sure it is up-to-date (working directory should be clean!). 
-Execute `./create-release.sh`. Now there should be two new `*.tar.gz` files.
-
-### Release
-
-Go to [the release section on GitHub](https://github.com/elan-ev/opencast-studio/releases) and click "Draft a new release". Click on "choose a tag" and enter the current date in YYYY-MM-DD and then "Create new tag".
-Make sure the target is still `master`.
-As a release title, enter the current date again in the same format.
-List all changes (since the last release) in the text box.
-Upload the two `*.tar.gz` files and click "Publish release".
-
-### Update Opencast
-
-Checkout a new branch. 
-Go to `modules/studio/pom.xml`. You have to change two lines:
-- `<opencast.studio.url>`: change the url to the new relase-url from `*-integrated.tar.gz`. (Usually only the date has to be adjusted here.)
-- `<opencast.studio.sha256>`: update the sha256 hash. (Run `sha256sum *-integrated.tar.gz` in Opencast Studio folder)
- Open a new pull request (optional: add a link to the release and changelog in the description)
-
- Before opening a new pull request, you can build Opencast and test Opencast Studio. The release date should be on the info page.

doc/make-release.md

@@ -0,0 +1,22 @@
+# How to release Opencast Studio
+
+Checkout the branch `master` from Opencast Studio and make sure it is up-to-date (working directory should be clean!).
+Execute `./create-release.sh`. Now there should be two new `*.tar.gz` files.
+
+## Release
+
+Go to [the release section on GitHub](https://github.com/elan-ev/opencast-studio/releases) and click "Draft a new release". Click on "choose a tag" and enter the current date in YYYY-MM-DD and then "Create new tag".
+Make sure the target is still `master`.
+As a release title, enter the current date again in the same format.
+List all changes (since the last release) in the text box.
+Upload the two `*.tar.gz` files and click "Publish release".
+
+## Update Opencast
+
+Checkout a new branch.
+Go to `modules/studio/pom.xml`. You have to change two lines:
+- `<opencast.studio.url>`: change the url to the new relase-url from `*-integrated.tar.gz`. (Usually only the date has to be adjusted here.)
+- `<opencast.studio.sha256>`: update the sha256 hash. (Run `sha256sum *-integrated.tar.gz` in Opencast Studio folder)
+ Open a new pull request (optional: add a link to the release and changelog in the description)
+
+ Before opening a new pull request, you can build Opencast and test Opencast Studio. The release date should be on the info page.