Split ci action into two jobs to start deploy faster
#1073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes elan-ev#921 Now almost everything that is not required for the test deployment lives in its own job now ("test"). Getting this work was a huge undertaking, because straight forward ways to do that don't work. See elan-ev#921 for some of the encountered problems. The gist of the current setup is: - There is the job `build` in `ci.yml` - Builds the Tobira binary - Creates an artifact with everything required for deployment - Creates another artifact with `frontend/build` - There is a job `test` in `ci.yaml` - It `needs: build`, so only starts afterwards - It downloads both artifacts and the backend cache - Runs all tests (`cargo test`, Playwright, ...) - `deploy.yml` - Is now triggered on `workflow_run: requested` instead of `completed`. Bc `completed` would also wait for `test` job. Instead, we manually wait for the `build` job to be finished.
|
I'd be lying if I said I understand everything that's going on here. But I didn't see any leftover code and the parts I do understand look good to me. |
|
Also I am very happy about this change! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #921
Now almost everything that is not required for the test deployment lives in its own job now ("test"). Getting this work was a huge undertaking, because straight forward ways to do that don't work. See #921 for some of the encountered problems. The gist of the current setup is:
buildinci.ymlfrontend/buildtestinci.yamlneeds: build, so only starts afterwardscargo test, Playwright, ...)deploy.ymlworkflow_run: requestedinstead ofcompleted. Bccompletedwould also wait fortestjob. Instead, we manually wait for thebuildjob to be finished.Behavior differences after merging this:
And as usual with these PRs: the
deploy.ymlfrom master is used, so this PR won't properly deploy. In fact the deploy run will fail.