Skip to content

added setting to disable SSL certificate verification #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

added setting to disable SSL certificate verification #108

wants to merge 1 commit into from

Conversation

beniwohli
Copy link
Contributor

@beniwohli beniwohli commented Dec 1, 2017 •
edited
Loading

replaces #97

@beniwohli beniwohli mentioned this pull request Dec 1, 2017
Closed
simitt
simitt reviewed Dec 4, 2017
View reviewed changes
Copy link
Contributor

@simitt simitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you align the naming a bit, currently you use
verify_server_cert, verify_certificateandverify_ssl` for the same setting.

@beniwohli beniwohli force-pushed the feature/disable-ssl-verification-config-v2 branch from fc653ce to 2a9e338 Compare December 4, 2017 09:38
@beniwohli
Copy link
Contributor Author

@simitt changed verify_certificate to verify_server_cert. verify_ssl is given by the library we use, so can't align that one.

@beniwohli beniwohli closed this in 57f41c7 Dec 4, 2017
@beniwohli beniwohli deleted the feature/disable-ssl-verification-config-v2 branch December 4, 2017 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simitt simitt simitt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@beniwohli @simitt