-
Notifications
You must be signed in to change notification settings - Fork 230
implement dropping of fast exit spans #1418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
events[event_type].append(event) | ||
|
||
store = Tracer(lambda: frames, lambda frames: frames, queue, Config(), None) | ||
store = Tracer(lambda: frames, lambda frames: frames, queue, elasticapm_client.config, elasticapm_client) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change was needed so that the tests that use this fixture also respect the default settings we set up in the elasticapm_client
fixture
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. 🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a hunch this was where the conversation about adding microseconds happened, so I checked the spec and added one note below. Otherwise looks great!
closes #1309