handle Django 1.10/1.11 with MIDDLEWARE_CLASSES correctly
#189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case of Django 1.10/1.11, the `MIDDLEWARE` attribute is there, but may be set to `None` if the old `MIDDLEWARE_CLASSES` setting is still used. This change will also ensure that the correct setting name is used in the error message of the management command. fixes elastic#188
|
Great! |
|
Merged manually? |
|
yes :) I don't use the github merge button as it can't sign the merge commit with my PGP key :) We will do a release that includes this fix in the next few days |
|
Great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of Django 1.10/1.11, the
MIDDLEWAREattribute is there,but may be set to
Noneif the oldMIDDLEWARE_CLASSESsetting is stillused.
This change will also ensure that the correct setting name is used in the
error message of the management command.
fixes #188