tests: remove some flakyness from client tests #2375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update test_send_remote_failover_sync_non_transport_exception_error to remove some flakyness: - use a custom transport class instead of mocking it because *sometime* the send method won't get mocked :O - then before asserting the transport state give it a bit more slack time to the queue to process and flush the data - Finally retry the check of the stat for the send without error to give the queue enough time to process it
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
xrmx
changed the title
basepi
approved these changes
Aug 1, 2025
|
These tests have always been a bit annoying. Hopefully this helps! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Update test_send_remote_failover_sync_non_transport_exception_error to remove some flakyness:
Related issues
Closes #2364