added max-event-queue-length setting
#67
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
force-pushed
the
feature/max-queue-length
branch
2 times, most recently
from
85099b6 to
5eb2f80
Compare
simitt
reviewed
Oct 3, 2017
| while a higher value can increase the memory pressure of your app. | ||
| A higher value also impacts the time until transactions are indexed and searchable in Elasticsearch. | ||
|
|
||
| This setting is useful to limit memory consumption if you experience a sudden spike of traffic. |
There was a problem hiding this comment.
Since there is no default value, could you add a note or link to the description of what the default value for sending events is?
|
|
||
| def test_should_not_collect_count(): | ||
| requests_store = TransactionsStore(lambda: [], collect_frequency=5, max_queue_length=5) | ||
| requests_store._transactions = 4 * [1] |
There was a problem hiding this comment.
could you align the formatting with the above test?
| requests_store = TransactionsStore(lambda: [], collect_frequency=5, max_queue_length=5) | ||
| requests_store._transactions = 6*[1] | ||
|
|
||
| assert requests_store.should_collect() |
There was a problem hiding this comment.
could you also set requests_store._last_collect -= 3 to show that the count overrides the time?
beniwohli
force-pushed
the
feature/max-queue-length
branch
from
5eb2f80 to
b993f2a
Compare
This allows to limit the total amount of transactions in the queue, e.g. to limit the memory consumption with a sudden traffic spike
beniwohli
force-pushed
the
feature/max-queue-length
branch
from
b993f2a to
e43dbe0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to limit the total amount of transactions in the queue, e.g.
to limit the memory consumption with a sudden traffic spike