use processors for transactions, and test that it actually happens #84
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
force-pushed
the
issue/transaction-processors
branch
from
eac26e2 to
0a56223
Compare
jalvz
reviewed
Nov 2, 2017
tests/processors/tests.py
Outdated
| return data | ||
|
|
||
|
|
||
| @mock.patch('tests.processors.tests.dummy_processor', wraps=dummy_processor) |
There was a problem hiding this comment.
this is totally up to you, but in this case is soooo easy to test without mocks, just have the dummy processor to actually do something....
jalvz
approved these changes
Nov 2, 2017
beniwohli
force-pushed
the
issue/transaction-processors
branch
from
0a56223 to
3573a6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.