Skip to content

Improve go docs #168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2022
Merged

Improve go docs #168

merged 3 commits into from
Mar 31, 2022

Conversation

estolfo
Copy link
Contributor

@estolfo estolfo commented Mar 31, 2022

Resolves #154

@estolfo estolfo requested a review from jlvoiseux March 31, 2022 11:38
@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Mar 31, 2022
@ghost
Copy link

ghost commented Mar 31, 2022 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-03-31T12:15:39.997+0000

  • Duration: 12 min 25 sec

Test stats 🧪

Test Results
Failed 0
Passed 240
Skipped 6
Total 246

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

jlvoiseux
jlvoiseux reviewed Mar 31, 2022
View reviewed changes
Copy link
Contributor

@jlvoiseux jlvoiseux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !
Two small suggestions below :

estolfo and others added 2 commits March 31, 2022 14:14
@estolfo @jlvoiseux
Update apm-lambda-extension/extension/apm_server.go
d441bc8 
Co-authored-by: Jean-Louis Voiseux <48380853+jlvoiseux@users.noreply.github.com>
@estolfo @jlvoiseux
Update apm-lambda-extension/extension/apm_server.go
3949b9a 
Co-authored-by: Jean-Louis Voiseux <48380853+jlvoiseux@users.noreply.github.com>
@estolfo estolfo requested a review from jlvoiseux March 31, 2022 12:14
@estolfo estolfo merged commit 3ad7982 into main Mar 31, 2022
@estolfo estolfo deleted the estolfo/godocs branch March 31, 2022 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@jlvoiseux jlvoiseux jlvoiseux approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more detailed code docs
2 participants
@estolfo @jlvoiseux