refactor: redesign logs api #248
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a logsapi client and add functional options to make it more flexible in local or testing environments. Add support for graceful shutdown to the HTTP server and only stop it after the event has been processed to avoid race conditions on the log channel. Add more detailed errors and make sure they are wrapped to provide appropriate context. Rename and move code around for clarity.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsTo re-run your PR in the CI, just comment with:
|
axw
reviewed
Jul 22, 2022
If StartService fails we can't assume the server started, so we have the method clean after itself in case of error to improve clarity and correctness.
Do not try to start the service if the logsapi is disabled. Use defer clause to shutdown the service.
Basic test to make sure the log listener is handling request correctly.
axw
reviewed
Jul 25, 2022
|
Thank you for the feedback! 🙇 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a logsapi client and add functional options to make it more
flexible in local or testing environments.
Add support for graceful shutdown to the HTTP server and only stop it
after the event has been processed to avoid race conditions on the log
channel.
Add more detailed errors and make sure they are wrapped to provide
appropriate context.
Rename and move code around for clarity.