Skip to content

Conversation

kruskall
Copy link
Member

@kruskall kruskall commented Oct 8, 2022

Companion PR to #310

Add job definition

@github-actions github-actions bot added the aws-λ-extension AWS Lambda Extension label Oct 8, 2022
@kruskall kruskall requested a review from v1v October 8, 2022 15:16
@ghost
Copy link

ghost commented Oct 8, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-10-11T13:27:32.479+0000

  • Duration: 8 min 54 sec

Test stats 🧪

Test Results
Failed 0
Passed 164
Skipped 2
Total 166

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some questions regarding when this particular job should run, see #310 (comment)

Those answers might imply some changes in this PR.

At the moment, the current changes will imply:

  • Run always for every push in any PR or main.

If you can clarify when this job should run we can configure it accordingly.

OTOH, I normally like to keep support for PRs, and disable the automation for triggering the build for those PRs if needed. Hence, it's possible to run the pipeline for any PR manually (using the Jenkins UI, or even a GitHub comment), that's handy when testing changes related to the pipeline itself.

Co-authored-by: Victor Martinez <victormartinezrubio@gmail.com>
@kruskall
Copy link
Member Author

OTOH, I normally like to keep support for PRs, and disable the automation for triggering the build for those PRs if needed. Hence, it's possible to run the pipeline for any PR manually (using the Jenkins UI, or even a GitHub comment), that's handy when testing changes related to the pipeline itself.

Agree, I think it's okay to only run it on main.

@kruskall kruskall requested a review from v1v October 11, 2022 13:30
@v1v v1v merged commit a73217c into elastic:main Oct 11, 2022
@kruskall kruskall deleted the ci/smoke-test-job branch October 11, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-λ-extension AWS Lambda Extension
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants