Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump elastic-agent-client to v7.1.2 #10923

Merged
merged 3 commits into from
Jun 2, 2023
Merged

Conversation

faec
Copy link
Contributor

@faec faec commented Jun 1, 2023

Dependency-only change, created with:

go get github.com/elastic/elastic-agent-client/v7@v7.1.2
go mod tidy
make check-full

The new version of elastic-agent-client includes a fix for a serious log spam issue that has come up in a lot of support cases.

@faec faec requested a review from apmmachine June 1, 2023 14:46
@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2023

This pull request does not have a backport label. Could you fix it @faec? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-7.x is the label to automatically backport to the 7.x branch.
  • backport-7./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jun 1, 2023
@apmmachine
Copy link
Contributor

apmmachine commented Jun 1, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-01T17:17:46.221+0000

  • Duration: 6 min 44 sec

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate and publish the docker images.

  • /test windows : Build & tests on Windows.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@apmmachine
Copy link
Contributor

apmmachine commented Jun 1, 2023

📚 Go benchmark report

Diff with the main branch

goos: linux
goarch: amd64
pkg: github.com/elastic/apm-server/internal/agentcfg
cpu: 12th Gen Intel(R) Core(TM) i5-12500
                                  │ build/main/bench.out │              bench.out              │
                                  │        sec/op        │    sec/op     vs base               │
FetchAndAdd/FetchFromCache-12                41.13n ± 0%    46.12n ± 4%  +12.13% (p=0.002 n=6)
FetchAndAdd/FetchAndAddToCache-12            91.71n ± 1%   102.30n ± 1%  +11.55% (p=0.002 n=6)
geomean                                      61.42n         68.69n       +11.84%

                                  │ build/main/bench.out │             bench.out              │
                                  │         B/op         │    B/op     vs base                │
geomean                                                ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                  │ build/main/bench.out │             bench.out              │
                                  │      allocs/op       │ allocs/op   vs base                │
geomean                                                ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/internal/beater/request
                                             │ build/main/bench.out │              bench.out              │
                                             │        sec/op        │    sec/op     vs base               │
ContextResetContentEncoding/empty-12                   116.8n ±  1%   131.1n ±  1%  +12.20% (p=0.002 n=6)
ContextResetContentEncoding/uncompressed-12            140.0n ±  1%   157.1n ±  2%  +12.21% (p=0.002 n=6)
geomean                                                940.5n         943.4n         +0.31%

                                             │ build/main/bench.out │              bench.out               │
                                             │         B/op         │     B/op      vs base                │
geomean                                                           ²                 +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

                                             │ build/main/bench.out │             bench.out              │
                                             │      allocs/op       │ allocs/op   vs base                │
geomean                                                           ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/internal/publish
             │ build/main/bench.out │            bench.out             │
             │        sec/op        │   sec/op    vs base              │
Publisher-12             1.004 ± 0%   1.003 ± 0%  -0.05% (p=0.015 n=6)

             │ build/main/bench.out │           bench.out            │
             │         B/op         │     B/op       vs base         │

             │ build/main/bench.out │           bench.out           │
             │      allocs/op       │  allocs/op    vs base         │

pkg: github.com/elastic/apm-server/x-pack/apm-server/aggregation/spanmetrics
                 │ build/main/bench.out │           bench.out           │
                 │        sec/op        │    sec/op     vs base         │

                 │ build/main/bench.out │            bench.out            │
                 │         B/op         │     B/op      vs base           │
¹ all samples are equal

                 │ build/main/bench.out │           bench.out           │
                 │      allocs/op       │ allocs/op   vs base           │
¹ all samples are equal

pkg: github.com/elastic/apm-server/x-pack/apm-server/aggregation/txmetrics
                        │ build/main/bench.out │          bench.out           │
                        │        sec/op        │   sec/op     vs base         │

                        │ build/main/bench.out │           bench.out           │
                        │         B/op         │    B/op     vs base           │
¹ all samples are equal

                        │ build/main/bench.out │           bench.out           │
                        │      allocs/op       │ allocs/op   vs base           │
¹ all samples are equal

pkg: github.com/elastic/apm-server/x-pack/apm-server/sampling
               │ build/main/bench.out │             bench.out              │
               │        sec/op        │    sec/op     vs base              │
geomean                  616.6n         603.3n        -2.16%

               │ build/main/bench.out │              bench.out               │
               │         B/op         │     B/op      vs base                │
geomean                             ²                 -0.02%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

               │ build/main/bench.out │             bench.out              │
               │      allocs/op       │ allocs/op   vs base                │
geomean                             ²               +0.00%               ²
¹ all samples are equal
² summaries must be >0 to compute geomean

pkg: github.com/elastic/apm-server/x-pack/apm-server/sampling/eventstorage
                                            │ build/main/bench.out │               bench.out               │
                                            │        sec/op        │    sec/op      vs base                │
WriteTransaction/json_codec-12                       4.264µ ±  19%   11.715µ ± 60%  +174.71% (p=0.004 n=6)
WriteTransaction/json_codec_big_tx-12                5.002µ ±   3%   13.337µ ± 54%  +166.65% (p=0.002 n=6)
ReadEvents/json_codec/0_events-12                    310.8n ±   7%    356.6n ±  6%   +14.77% (p=0.002 n=6)
ReadEvents/json_codec_big_tx/0_events-12             299.9n ±  10%    353.6n ±  9%   +17.91% (p=0.004 n=6)
ReadEvents/json_codec_big_tx/1_events-12             12.05µ ±   6%    12.96µ ±  2%    +7.55% (p=0.004 n=6)
ReadEvents/json_codec_big_tx/100_events-12           1.019m ±   4%    1.027m ±  2%    +0.79% (p=0.041 n=6)
ReadEvents/nop_codec/0_events-12                     314.0n ±   6%    341.0n ±  5%    +8.61% (p=0.002 n=6)
ReadEvents/nop_codec_big_tx/0_events-12              298.7n ±   5%    343.3n ±  6%   +14.95% (p=0.002 n=6)
IsTraceSampled/sampled-12                            69.97n ±   3%    77.24n ±  4%   +10.38% (p=0.002 n=6)
IsTraceSampled/unsampled-12                          72.43n ±   2%    79.22n ±  2%    +9.39% (p=0.002 n=6)
IsTraceSampled/unknown-12                            368.6n ±   4%    413.8n ±  7%   +12.29% (p=0.002 n=6)
geomean                                              29.18µ           31.09µ          +6.53%

                                            │ build/main/bench.out │               bench.out                │
                                            │         B/op         │      B/op       vs base                │
WriteTransaction/json_codec_big_tx-12                3.686Ki ±  0%    3.688Ki ±  0%  +0.05% (p=0.006 n=6)
ReadEvents/nop_codec_big_tx/100_events-12            244.8Ki ±  0%    244.6Ki ±  0%  -0.09% (p=0.004 n=6)
geomean                                              31.36Ki          31.36Ki        -0.02%
¹ all samples are equal

                                            │ build/main/bench.out │              bench.out              │
                                            │      allocs/op       │  allocs/op   vs base                │
geomean                                                 144.7         144.7       +0.00%
¹ all samples are equal

report generated with https://pkg.go.dev/golang.org/x/perf/cmd/benchstat

@mergify
Copy link
Contributor

mergify bot commented Jun 1, 2023

This pull request is now in conflicts. Could you fix it @faec? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b agent-client-update upstream/agent-client-update
git merge upstream/main
git push upstream agent-client-update

@axw axw added the backport-8.8 Automated backport with mergify label Jun 2, 2023
@mergify mergify bot removed the backport-skip Skip notification from the automated backport with mergify label Jun 2, 2023
@axw axw merged commit 2cf7699 into elastic:main Jun 2, 2023
mergify bot pushed a commit that referenced this pull request Jun 2, 2023
* Bump elastic-agent-client to v7.1.2

* make check-full

(cherry picked from commit 2cf7699)

# Conflicts:
#	go.mod
#	go.sum
@faec faec deleted the agent-client-update branch June 2, 2023 11:46
carsonip added a commit that referenced this pull request Jun 2, 2023
carsonip added a commit that referenced this pull request Jun 2, 2023
mergify bot added a commit that referenced this pull request Jun 2, 2023
* Bump elastic-agent-client to v7.1.2 (#10923)

* Bump elastic-agent-client to v7.1.2

* make check-full

(cherry picked from commit 2cf7699)

# Conflicts:
#	go.mod
#	go.sum

* Bump elastic-agent-client to v7.1.2 (#10923)

* Revert "Bump elastic-agent-client to v7.1.2 (#10923)"

This reverts commit aca341b.

* make check-full

---------

Co-authored-by: Fae Charlton <fae.charlton@elastic.co>
Co-authored-by: Carson Ip <carson.ip@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.8 Automated backport with mergify
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants