Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metricbeat Consul Overview Dashboard #10665

Merged

Conversation

sayden
Copy link
Contributor

@sayden sayden commented Feb 11, 2019

An overview dashboard for Consul module.

image

@sayden sayden added enhancement in progress Pull request is currently in progress. Metricbeat Metricbeat :Dashboards labels Feb 11, 2019
@sayden sayden self-assigned this Feb 11, 2019
@sayden sayden requested a review from a team as a code owner February 11, 2019 11:06
@sayden sayden added the Team:Integrations Label for the Integrations team label Feb 11, 2019
@sayden sayden force-pushed the feature/mb/consul-overview-dashboard branch from 0ef0639 to 3ce15c2 Compare February 13, 2019 17:23
@sayden sayden requested a review from a team as a code owner February 13, 2019 17:23
@sayden sayden force-pushed the feature/mb/consul-overview-dashboard branch from 3ce15c2 to 1640217 Compare February 18, 2019 10:43
@sayden sayden force-pushed the feature/mb/consul-overview-dashboard branch from 1640217 to 81a7855 Compare April 23, 2019 19:10
@sayden sayden force-pushed the feature/mb/consul-overview-dashboard branch 2 times, most recently from d5942aa to 7030994 Compare April 29, 2019 11:32
@sayden sayden added review [zube]: In Review and removed in progress Pull request is currently in progress. [zube]: Backlog labels Apr 29, 2019
Copy link
Contributor

@odacremolbap odacremolbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

Garbage Collector stats [Metricbeat Consul]
I think showing only the pause time bars looks a lot better than showing pause time as dots, under a bar per gc run.
There is another visualization of GC runs already, so that information is redundant at the graph.

Heap Objects [Metricbeat Consul]
I think heap objects are number of instead of size of

Malloc count [Metricbeat Consul]
Same as above, I think this is the total count of malloc operations

@sayden sayden force-pushed the feature/mb/consul-overview-dashboard branch from 7030994 to 08b401a Compare May 21, 2019 14:26
@odacremolbap odacremolbap self-requested a review May 21, 2019 15:00
Copy link
Contributor

@odacremolbap odacremolbap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Fixing types ... using previous version of dashboard file, since tests where failing with previous version
@odacremolbap odacremolbap merged commit dcc68a0 into elastic:master May 21, 2019
@odacremolbap odacremolbap deleted the feature/mb/consul-overview-dashboard branch May 21, 2019 23:22
@sayden
Copy link
Contributor Author

sayden commented May 22, 2019

Thanks Pablo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants