-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.0] Backport: Add release highlights #11708
Conversation
* Add release highlights * Rework highlights * Add fixes from review * Use attribute
e2e264d
to
874d70a
Compare
popular open-source Zeek project, formerly known as Bro, and a | ||
{filebeat-ref}/filebeat-module-santa.html[Santa] module, which tracks process | ||
executions on macOS. These modules add to the list of data sources already | ||
supported in the 6.x series, including |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this sentence differs from the original PR? In the original PR it says:
... list of modules added already in the 6.x series, ...
Whereas over here in this PR the same sentence says:
... list of data sources already supported in the 6.x series, ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah never mind, I just read your PR description, specifically:
I've changed the language to indicate that NetFlow is a supported input.
And I noticed the commit that goes with this change as well: 874d70a.
So all good here!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ycombinator yup! Because the NetFlow module is not available in the 6.x series, nor is it in 7.0. It's supported as an input in those releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Cherry-picks #11621 into the 7.0 branch.
I have removed NetFlow because it does not appear to exist in 7.0.I've changed the language to indicate that NetFlow is a supported input.