Validate that kibana/status metricset cannot be used with xpack.enabled: true #12264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
bug
module
Metricbeat
|
Pinging @elastic/stack-monitoring |
ruflin
approved these changes
May 24, 2019
cachedout
approved these changes
May 24, 2019
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
….enabled: true (elastic#12264) (elastic#12276) * Validate that kibana/status metricset cannot be used with xpack.enabled: true * Adding CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
kibana/statusmetricset doesn't have an x-pack code path (used for stack monitoring). Yet, prior to this PR we would allow users to enable thekibana/statusmetricset AND setxpack.enabled: true. This would result in unexpected and invalid behavior.With this PR if this combination is detected, an error is thrown.