Refactoring of entry reading #12716
Merged
Refactoring of entry reading #12716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalpristas
approved these changes
Jun 28, 2019
|
Failing tests are unrelated. |
kvch
added a commit
to kvch/beats
that referenced
this pull request
Aug 8, 2019
I have cleaned up the coda around reading entries and fixed an issue when iterating through journals. Closes elastic#11505 (cherry picked from commit 3c9734c)
kvch
added a commit
that referenced
this pull request
Aug 8, 2019
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
I have cleaned up the coda around reading entries and fixed an issue when iterating through journals. Closes elastic#11505
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
Original description: I have cleaned up the coda around reading entries and fixed an issue when iterating through journals. Closes elastic#11505 (cherry picked from commit 3c9734c) Closes elastic#13123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have cleaned up the coda around reading entries and fixed an issue when iterating through journals.
Closes #11505