Fix pull on ContainerStart wrapper used in tests #15511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ContainerStart wrapper used in tests was not waiting for the pull to finish, causing flakiness, e.g. in the `TestDockerStart`.
jsoriano
added
review
needs_backport
|
jenkins, test this again please |
mtojek
approved these changes
Jan 14, 2020
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Jan 14, 2020
ContainerStart wrapper used in tests was not waiting for the pull to finish, causing flakiness, e.g. in TestDockerStart. Pull can be waited to finish by calling to Close() in the response body. This is also something that has to be done at some moment to avoid leaks. Also add some more context on error messages. (cherry picked from commit dd553b3)
jsoriano
removed
the
needs_backport
jsoriano
added a commit
that referenced
this pull request
Jan 14, 2020
ContainerStart wrapper used in tests was not waiting for the pull to finish, causing flakiness, e.g. in TestDockerStart. Pull can be waited to finish by calling to Close() in the response body. This is also something that has to be done at some moment to avoid leaks. Also add some more context on error messages. (cherry picked from commit dd553b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ContainerStart wrapper used in tests was not waiting for the pull to
finish, causing flakiness, e.g. in
TestDockerStart. Pull can bewaited to finish by calling to
Close()in the response body. This isalso something that has to be done at some moment to avoid leaks.
Also add some more context on error messages.