Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation about tool dependencies #16107

Merged
merged 5 commits into from
Feb 6, 2020

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Feb 5, 2020

What does this PR do?

This PR adds information about tool dependencies to the contribution guide.

Why is it important?

Previously we did not specify what tools were required to run go generate in the repo.

Checklist

  • I have made corresponding changes to the documentation
    - [ ] My code follows the style guidelines of this project
    - [ ] I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works

Related issues

#15998

@kvch kvch added docs [zube]: In Review Team:Services (Deprecated) Label for the former Integrations-Services team labels Feb 5, 2020
docs/devguide/contributing.asciidoc Outdated Show resolved Hide resolved
docs/devguide/contributing.asciidoc Outdated Show resolved Hide resolved
docs/devguide/contributing.asciidoc Outdated Show resolved Hide resolved
docs/devguide/contributing.asciidoc Show resolved Hide resolved
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few nits, otherwise looks good.

kvch and others added 2 commits February 5, 2020 19:23
Co-Authored-By: Andrew Kroh <andrew.kroh@elastic.co>
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kvch
Copy link
Contributor Author

kvch commented Feb 6, 2020

Docs build is passing, merging.

@kvch kvch merged commit b1c6041 into elastic:master Feb 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants