Agent configuration tweaks #16240
Agent configuration tweaks #16240
Conversation
ph
commented
Feb 11, 2020
•
ph
commented
- Added period for the system/metrics
- Remove a few slashes for dataset.
- Move queue_url to the input level followed @kaiyan-sheng's advice.
- double-check credentials support for AWS
- Added period for the system/metrics - Remove a few slashes for dataset. - Move queue_url to the input level followed @kaiyan-sheng's [advice](elastic#15940 (comment)).
|
Pinging @elastic/ingest (Project:fleet) |
|
fyi @michalpristas |
|
@ruflin Changes made lets get this in. |
| - metricset: process | ||
| dataset: system.process | ||
| processes: ["firefox*"] | ||
| include_top_n: |
There was a problem hiding this comment.
is this something we understand or is it input/processor config?
There was a problem hiding this comment.
This is something we relay to the input module section in metricbeat. This required a bit of massaging:
beats/metricbeat/modules.d/system.yml
Lines 19 to 22 in 69cd8d8
There was a problem hiding this comment.
in this case it's fine
| - id?: {id} | ||
| metricset: s3access | ||
| dataset: aws/s3access | ||
| dataset: aws.s3access |
There was a problem hiding this comment.
will we provide some mapping logic between dataset-metricset in case metricset is missing?
There was a problem hiding this comment.
This could become tricky as we would need a lookup. It is not always straight forward.
There was a problem hiding this comment.
So in this case explicit >= magic :)
There was a problem hiding this comment.
so we should always have metricset stated in case of metricbeat input
There was a problem hiding this comment.
Yes, we would say that metricset is indeed mandatory, without that we cannot pick up the right module when launching metricbeat and we configure the module with a custom option like {metricset}.include_top_n
* Agent tweaks - Added period for the system/metrics - Remove a few slashes for dataset. - Move queue_url to the input level followed @kaiyan-sheng's [advice](elastic#15940 (comment)). * few issues with aws * Define queue on stream.
