Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libbeat] rename queue.Eventer -> queue.ACKListener #16691

Merged
merged 3 commits into from
Feb 28, 2020
Merged

[libbeat] rename queue.Eventer -> queue.ACKListener #16691

merged 3 commits into from
Feb 28, 2020

Conversation

faec
Copy link
Contributor

@faec faec commented Feb 28, 2020

What does this PR do?

queue.Eventer is an interface definition for types that can receive OnACK(eventCount int) calls, and is implemented by types that need to listen for incoming event ACKs. This PR renames it queue.ACKListener to better convey its purpose.

This PR introduces no user-visible changes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

@faec faec requested a review from urso February 28, 2020 17:03
urso
urso approved these changes Feb 28, 2020
View reviewed changes
Copy link

@urso urso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a much better name :)

@faec faec merged commit 31b9426 into elastic:master Feb 28, 2020
@faec faec mentioned this pull request Mar 3, 2020
Merged
5 tasks
@faec faec added the v7.7.0 label Mar 3, 2020
faec added a commit to faec/beats that referenced this pull request Mar 3, 2020
@faec
[libbeat] rename queue.Eventer -> queue.ACKListener (elastic#16691)
0170d1f 
(cherry picked from commit 31b9426)
@faec faec deleted the ack-listener branch March 4, 2020 18:15
faec added a commit that referenced this pull request Mar 5, 2020
@faec
[libbeat] rename queue.Eventer -> queue.ACKListener (#16691) (#16765)
9034211 
(cherry picked from commit 31b9426)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

Assignees
No one assigned
Labels
cleanup libbeat v7.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@faec @urso