Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #17001 to 7.x: Increase HTTP client timeout in kubernetes state_deployment tests #17006

Merged
merged 1 commit into from
Mar 20, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Mar 13, 2020

Cherry-pick of PR #17001 to 7.x branch. Original message:

Test data for state_deployment metricset is quite big, and the metricset
may need more than the 10 seconds default timeout of HTTP clients,
provoking sporadic failures in CI.
Increase this timeout for this case.

This should fix flaky tests like:

10:55:29 --- FAIL: TestData (12.25s)
10:55:29     --- FAIL: TestData/ksm-v1.8.0.plain (11.22s)
10:55:29         testdata.go:272: Event was not expected: {"error":{"message":"decoding of metric family failed: net/http: request canceled (Client.Timeout exceeded while reading body)"},"event":{"dataset":"kubernetes.state_deployment","duration":115000,"module":"kubernetes"},"metricset":{"name":"state_deployment","period":10000},"service":{"address":"127.0.0.1:55555","type":"kubernetes"}}
10:55:29         testdata.go:277: Some events were missing:
...
10:55:29         testdata.go:281: 
10:55:29 FAIL
10:55:29 coverage: 74.1% of statements
10:55:29 FAIL	github.com/elastic/beats/v7/metricbeat/module/kubernetes/state_deployment	12.588s

…astic#17001)

Test data for state_deployment metricset is quite big, and the metricset
may need more than the 10 seconds default timeout of HTTP clients,
provoking sporadic failures in CI. Increase this timeout for this case.

(cherry picked from commit 610f996)
@jsoriano jsoriano merged commit 3f00103 into elastic:7.x Mar 20, 2020
@jsoriano jsoriano deleted the backport_17001_7.x branch March 20, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants