Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing typos in JSON field names #17088

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

ycombinator
Copy link
Contributor

What does this PR do?

Fix typos introduced in #16538.

Why is it important?

So the correct field names are used when indexing type: index_stats data into .monitoring-es-* indices.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works

@ycombinator ycombinator added [zube]: In Review Feature:Stack Monitoring Team:Services (Deprecated) Label for the former Integrations-Services team v7.7.0 v8.0.0 labels Mar 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/stack-monitoring (Stack monitoring)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-services (Team:Services)

@zube zube bot removed the v7.6.2 label Mar 18, 2020
@ycombinator ycombinator added the needs_backport PR is waiting to be backported to other branches. label Mar 18, 2020
Copy link
Contributor

@chrisronline chrisronline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

{
  "hits": {
    "hits": [
      {
        "_source": {
          "index_stats": {
            "total": {
              "search": {
                "query_total": 398,
                "query_time_in_millis": 432
              },
              "fielddata": {
                "memory_size_in_bytes": 1344,
                "evictions": 0
              },
              "indexing": {
                "index_total": 374,
                "index_time_in_millis": 404,
                "throttle_time_in_millis": 0
              },
              "store": {
                "size_in_bytes": 443322
              },
              "refresh": {
                "external_total_time_in_millis": 3846,
                "total_time_in_millis": 3663
              },
              "segments": {
                "terms_memory_in_bytes": 67840,
                "index_writer_memory_in_bytes": 0,
                "count": 10,
                "norms_memory_in_bytes": 0,
                "version_map_memory_in_bytes": 0,
                "term_vectors_memory_in_bytes": 0,
                "points_memory_in_bytes": 0,
                "stored_fields_memory_in_bytes": 4944,
                "memory_in_bytes": 107352,
                "doc_values_memory_in_bytes": 34568,
                "fixed_bit_set_memory_in_bytes": 0
              },
              "docs": {
                "count": 374
              },
              "request_cache": {
                "evictions": 0,
                "hit_count": 15,
                "miss_count": 251,
                "memory_size_in_bytes": 7330
              },
              "merges": {
                "total_size_in_bytes": 6152784
              },
              "query_cache": {
                "hit_count": 0,
                "miss_count": 0,
                "memory_size_in_bytes": 0,
                "evictions": 0
              }
            },
            "uuid": "MIuBVme_QBiadsCw3e2rVw",
            "index": ".monitoring-beats-7-mb-2020.03.18",
            "created": 1584545718254,
            "status": "green",
            "shards": {
              "unassigned_total": 0,
              "total": 1,
              "replicas": 0,
              "active_total": 1,
              "active_primaries": 1,
              "initializing": 0,
              "relocating": 0,
              "unassigned_replicas": 0,
              "active_replicas": 0,
              "unassigned_primaries": 0,
              "primaries": 1
            },
            "primaries": {
              "store": {
                "size_in_bytes": 443322
              },
              "query_cache": {
                "miss_count": 0,
                "memory_size_in_bytes": 0,
                "evictions": 0,
                "hit_count": 0
              },
              "docs": {
                "count": 374
              },
              "indexing": {
                "index_total": 374,
                "index_time_in_millis": 404,
                "throttle_time_in_millis": 0
              },
              "search": {
                "query_time_in_millis": 432,
                "query_total": 398
              },
              "fielddata": {
                "memory_size_in_bytes": 1344,
                "evictions": 0
              },
              "request_cache": {
                "hit_count": 15,
                "miss_count": 251,
                "memory_size_in_bytes": 7330,
                "evictions": 0
              },
              "segments": {
                "fixed_bit_set_memory_in_bytes": 0,
                "version_map_memory_in_bytes": 0,
                "memory_in_bytes": 107352,
                "index_writer_memory_in_bytes": 0,
                "stored_fields_memory_in_bytes": 4944,
                "term_vectors_memory_in_bytes": 0,
                "points_memory_in_bytes": 0,
                "count": 10,
                "terms_memory_in_bytes": 67840,
                "norms_memory_in_bytes": 0,
                "doc_values_memory_in_bytes": 34568
              },
              "refresh": {
                "external_total_time_in_millis": 3846,
                "total_time_in_millis": 3663
              },
              "merges": {
                "total_size_in_bytes": 6152784
              }
            }
          }
        }
      }
    ]
  }
}

@ycombinator
Copy link
Contributor Author

Travis CI is green and Jenkins CI failures are unrelated. Merging.

@ycombinator ycombinator merged commit 6df166c into elastic:master Mar 18, 2020
@ycombinator ycombinator deleted the mb-es-index-fix-typos branch March 18, 2020 23:29
@ycombinator ycombinator added v7.6.3 and removed needs_backport PR is waiting to be backported to other branches. labels Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Stack Monitoring Team:Services (Deprecated) Label for the former Integrations-Services team v7.6.3 v7.7.0 v8.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants