[7.x] Separate ES client code from ES output code (#16150) #17222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
added
[zube]: In Review
backport
Team:Integrations
|
Pinging @elastic/integrations (Team:Integrations) |
ycombinator
commented
Mar 24, 2020
ycombinator
commented
Mar 24, 2020
ycombinator
commented
Mar 24, 2020
urso
approved these changes
Mar 24, 2020
ycombinator
force-pushed
the
backport/7.x/pr-16150
branch
4 times, most recently
from
90e64b1
to
8728851
Compare
* Basic extraction of ES client code from ES output code * Move test * Removing duplicate function in monitoring reporter * Break import cycle * Guard onConnect callback execution * Replace use of field with getter * Moving common bulk API response processing into esclientleg * Moving API integration tests * Fixing references in tests * Adding developer CHANGELOG entry * Move LoadJSON method * Move callbacks to own file * Move client-related constructors into client.go file * Reducing global logging usage * Use new constructor in test * Passing logger in test * Use logger in test * Use struct fieldnames when initializing * Use constructor in test * Fixing typos * Replace esclient.ParseProxyURL with generic function in common * Imports formatting * Moving more fields from ES output client to esclientleg.Connection * Moving more fields * Update test code * Use new TLS package * Extracting common test code into eslegtest package * Replace uses of elasticsearch output client with esclientleg.NewConnection * Replacing uses of ES output client struct with esclientleg.Connection * Handle callbacks * Fixing formatting * Fixing import cycle * Fixing import and package name * Fixing imports * More fixes * Breaking import cycle * Removing unused function * Adding back missing statement * Fixing param * Fixing package name * Include ES output plugin so it's registered * Proxy handling * Let Connection handle ProxyDisable setting * Only parse proxy field from config if set * Cast timeout ints * Parse proxy URL * Fixing proxy integration test * Fixing ILM test * Updating expected request count in test * Fixing package names * Lots more refactoring!!! * Move timeout field * More fixes * Adding missing files * No need to pass HTTP any more * Simplifying Bulk API usage * Removing unused code * Remove bulk state from Connection * Removing empty file * Moving Bulk API response streaming parsing code back into ES output package * Don't make monitoring bulk parsing code use streaming parser * Replacing old HTTP struct passing * Removing HTTP use * Adding build tag * Fixing up tests * Allow default scheme to be configurable * Adding versions to import paths * Remove redundant check * Undoing unnecessary heartbeat import change * Forgot to resolve conflicts * Fixing imports * Running go mod tidy * Revert "Remove redundant check" This reverts commit c5fde6ff3be765a89c0bc20f9cae8f697d08d47e. * Fixing args order * Removing extraneous parameter * Removing wrong errors package import * Fixing order of arguments * Fixing package name * Instantiating logger for tests * Making streaming JSON parser private to ES output package * Detect and try to fix scheme before parsing URL * Making Connection private to ES output Client * Update test * Replace client.Ping() calls with client.Connect() calls in test code * Updating tests * Removing usage of ES output from monitoring code! * Using strings.Index instead of strings.SplitN * Return default config via function call * Removing "escape hatch" method to expose underlying connection from ES output client * Using client connection in tests * Re-implement Test() method for ES output client
ycombinator
force-pushed
the
backport/7.x/pr-16150
branch
from
1d77a03
to
846c64a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.x: