fix application_pool metricset reader after pdh changes #18477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
narph
added
[zube]: In Review
Metricbeat
botelastic
bot
removed
the
needs_team
|
Pinging @elastic/integrations (Team:Integrations) |
zube
bot
added
[zube]: Inbox
[zube]: In Review
and removed
[zube]: In Review
[zube]: Inbox
labels
sayden
approved these changes
May 13, 2020
| re.log.Debugw("Ignoring the first measurement because the data isn't ready", | ||
| "error", val.Err, logp.Namespace("website"), "query", counterPath) | ||
| continue | ||
| if val.Err.Error != nil { |
There was a problem hiding this comment.
AFAICS val.Err and values could also be nil. Let's leave that change for a follow up PR
There was a problem hiding this comment.
values can be nil but that would also return an error and the check above that will make sure to exit before , https://github.com/elastic/beats/blob/master/metricbeat/helper/windows/pdh/pdh_query_windows.go#L176.
val.Err should not be nil also, it is instantiated here https://github.com/elastic/beats/blob/master/metricbeat/helper/windows/pdh/pdh_query_windows.go#L244
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
narph
added a commit
to narph/beats
that referenced
this pull request
May 13, 2020
* fix * changelog * mage fmt update (cherry picked from commit e20f856)
6 tasks
narph
added a commit
to narph/beats
that referenced
this pull request
May 13, 2020
* fix * changelog * mage fmt update (cherry picked from commit e20f856)
6 tasks
narph
added a commit
that referenced
this pull request
May 13, 2020
narph
added a commit
that referenced
this pull request
May 13, 2020
jsoriano
added a commit
that referenced
this pull request
May 15, 2020
Jenkins pipeline is not executing the tests on Windows and OSX for some x-pack beats, so we cannot detect specific issues on these platforms, like the compilation error in Windows solved by #18477, that was introduced after a green build. Run x-pack Filebeat and Metricbeat builds and unit tests in Windows and OSX.
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
May 15, 2020
…c#18494) Jenkins pipeline is not executing the tests on Windows and OSX for some x-pack beats, so we cannot detect specific issues on these platforms, like the compilation error in Windows solved by elastic#18477, that was introduced after a green build. Run x-pack Filebeat and Metricbeat builds and unit tests in Windows and OSX. (cherry picked from commit 0419a4d)
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
May 15, 2020
…c#18494) Jenkins pipeline is not executing the tests on Windows and OSX for some x-pack beats, so we cannot detect specific issues on these platforms, like the compilation error in Windows solved by elastic#18477, that was introduced after a green build. Run x-pack Filebeat and Metricbeat builds and unit tests in Windows and OSX. (cherry picked from commit 0419a4d)
jsoriano
added a commit
that referenced
this pull request
May 18, 2020
#18583) Jenkins pipeline is not executing the tests on Windows and OSX for some x-pack beats, so we cannot detect specific issues on these platforms, like the compilation error in Windows solved by #18477, that was introduced after a green build. Run x-pack Filebeat and Metricbeat builds and unit tests in Windows and OSX. (cherry picked from commit 0419a4d)
jsoriano
added a commit
that referenced
this pull request
May 18, 2020
#18584) Jenkins pipeline is not executing the tests on Windows and OSX for some x-pack beats, so we cannot detect specific issues on these platforms, like the compilation error in Windows solved by #18477, that was introduced after a green build. Run x-pack Filebeat and Metricbeat builds and unit tests in Windows and OSX. (cherry picked from commit 0419a4d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes tests and implementation in the iis/application_pool after pdh changes
Why is it important?
successful build
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.