index_pattern under visState.params cannot be empty ""
#18865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
needs_team
kaiyan-sheng
added
needs_backport
|
Pinging @elastic/integrations-platforms (Team:Platforms) |
botelastic
bot
removed
the
needs_team
❕ Build Aborted
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
exekias
reviewed
Jun 1, 2020
| @@ -270,13 +270,14 @@ type dashboardObject struct { | |||
| Title string `json:"title"` | |||
| KibanaSavedObjectMeta *struct { | |||
| SearchSourceJSON struct { | |||
| Index string `json:"index"` | |||
| Index *string `json:"index"` | |||
There was a problem hiding this comment.
why do we need a pointer here?
There was a problem hiding this comment.
I added a pointer here because I need to distinguish if this field exists or the value of this field is empty string "". Without the pointer, even if VisState.Params doesn't have IndexPattern field, it will return "".
jsoriano
approved these changes
Jun 2, 2020
There was a problem hiding this comment.
LGTM.
Looking at the affected dashboards, they seem to be some of the most recent ones, I wonder if something has changed in Kibana or the dashboards exporter that provokes this difference.
Maybe we can modify the dashboards exporter to fill these parameters with correct values.
...eat/module/kubernetes/_meta/kibana/7/dashboard/Metricbeat-kubernetes-controller-manager.json
Show resolved
Hide resolved
kaiyan-sheng
removed
the
needs_backport
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* `index_pattern` under visState.params cannot be empty ""
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…) (elastic#18943) * `index_pattern` under visState.params cannot be empty "" (cherry picked from commit fbe67a0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to add check to make sure
index_patternunder visState.params not be empty"". For example in metricbeat dashboard/visualization, when default index is notmetricbeat-*in Kibana and index_pattern is set to"", visualizations will take the default index pattern by default. If the default index pattern is notmetricbeat-*, then these dashboards will fail and show no data.This PR is to not only fix the rest of the dashboards having this issue but also adding the check in
mage/check.go.Related PR: #18698
Discuss Forum Link: https://discuss.elastic.co/t/metricbeats-dashboards-for-kubernetes-controller-manager/233402/4
This PR also improved the error message on which visualization failed the test: