-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Fix improper nesting of session_issuer in aws/cloudtrail #18915
Merged
leehinman
merged 2 commits into
elastic:master
from
leehinman:18894_cloudtrail_session_issuer
Jun 5, 2020
Merged
[Filebeat] Fix improper nesting of session_issuer in aws/cloudtrail #18915
leehinman
merged 2 commits into
elastic:master
from
leehinman:18894_cloudtrail_session_issuer
Jun 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leehinman
added
bug
Filebeat
Filebeat
needs_backport
PR is waiting to be backported to other branches.
Team:SIEM
labels
Jun 2, 2020
Pinging @elastic/siem (Team:SIEM) |
botelastic
bot
added
needs_team
Indicates that the issue/PR needs a Team:* label
and removed
needs_team
Indicates that the issue/PR needs a Team:* label
labels
Jun 2, 2020
pipeline & fields.yml had session issuer outside of the session context object. session issuer only appears inside the session context object. Not a breaking change because prior to this the data was being skipped. Closes elastic#18894
leehinman
force-pushed
the
18894_cloudtrail_session_issuer
branch
from
June 2, 2020 19:37
b878044
to
e71832b
Compare
andrewkroh
approved these changes
Jun 4, 2020
5 tasks
leehinman
added
v7.9.0
and removed
needs_backport
PR is waiting to be backported to other branches.
labels
Jun 5, 2020
leehinman
added a commit
to leehinman/beats
that referenced
this pull request
Jun 5, 2020
pipeline & fields.yml had session issuer outside of the session context object. session issuer only appears inside the session context object. Not a breaking change because prior to this the data was being skipped. Closes elastic#18894 (cherry picked from commit 632c086)
2 tasks
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
pipeline & fields.yml had session issuer outside of the session context object. session issuer only appears inside the session context object. Not a breaking change because prior to this the data was being skipped. Closes elastic#18894
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
session issuer object is now correctly inside session context object
Why is it important?
Data in session issuer object wasn't being mapped
Checklist
- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Related issues