Make user.id a string in system/users, in line with ECS #19019
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fearful-symmetry
added
bug
Metricbeat
|
Pinging @elastic/integrations (Team:Integrations) |
botelastic
bot
added
needs_team
|
This pull request doesn't have a |
jsoriano
approved these changes
Jun 6, 2020
urso
reviewed
Jun 8, 2020
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
urso
approved these changes
Jun 8, 2020
v1v
added a commit
to v1v/beats
that referenced
this pull request
Jun 12, 2020
…ngs-archive * upstream/master: (119 commits) Update filebeat input docs (elastic#19110) Add ECS fields from log pipeline of PostgreSQL (elastic#19127) Init package libbeat/statestore (elastic#19117) [Ingest Manager] Retryable downloads of beats (elastic#19102) [DOCS] Add output.console to Functionbeat doc and Functionbeat reference file (elastic#18965) Add compatibility info (elastic#18929) Set ecszap version to v0.2.0 (elastic#19106) [filebeat][httpjson] Fix unit test function call (elastic#19124) [Filebeat][httpjson] Adds oauth2 support for httpjson input (elastic#18892) Allow host.* fields to be disabled in Suricata module (elastic#19107) Make selector string casing configurable (elastic#18854) Switch the GRPC communication where Agent is running the server and the beats are connecting back to Agent (elastic#18973) Disable host.* fields by default for netflow module (elastic#19087) Automatically fill zube teams on backports if available (elastic#18924) Fix crash on vsphere module (elastic#19078) [Ingest Manager] Download snapshot artifacts from snapshots repo (elastic#18685) [Ingest Manager] Basic Elastic Agent documentation (elastic#19030) Make user.id a string in system/users, in line with ECS (elastic#19019) [docs] Add 7.8 release highlights placeholder file (elastic#18493) Fix translate_sid's empty target field handling (elastic#18991) ...
fearful-symmetry
added a commit
to fearful-symmetry/beats
that referenced
this pull request
Jun 15, 2020
* user.id must be a string * changelog entry * make it a breaking change (cherry picked from commit de57f06)
3 tasks
fearful-symmetry
removed
the
needs_backport
fearful-symmetry
added a commit
that referenced
this pull request
Jun 30, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
* user.id must be a string * changelog entry * make it a breaking change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This is a quick change to make the
user.idfield in thesystem/usersmetricset a keyword, which is what ECS wants: https://www.elastic.co/guide/en/ecs/current/ecs-user.htmlWhy is it important?
Metricset should be ECS compliant.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Testing
system/usermetricsetuser.idis a string, and not an int.