Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #19018 to 7.x: Add basic cloudfoundry integration tests #19160

Merged
merged 1 commit into from
Jun 15, 2020

Conversation

jsoriano
Copy link
Member

@jsoriano jsoriano commented Jun 12, 2020

Cherry-pick of PR #19018 to 7.x branch. Original message:

What does this PR do?

Add some basic integration tests for cloudfoundry.

By now these tests follow the approach we are following with cloud features, they need a cloud foundry deployment whose configuration is provided using environment variables, and tests are only executed if some tag is set. So they are not going to be executed in CI by now.

Instructions to have a working cloud foundry deployment will be added in a future PR.

Why is it important?

To have some integration tests as reference before starting with further refactors.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation Instructions to have a cloud foundry deployment for development will be added in a future PR.
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

export CLOUDFOUNDRY_API_ADDRESS=...
export CLOUDFOUNDRY_CLIENT_ID=...
export CLOUDFOUNDRY_CLIENT_SECRET=...
go test -tags=integration,cloudfoundry ./x-pack/filebeat/input/cloudfoundry/ ./x-pack/metricbeat/module/cloudfoundry/...

Related issues

  • Part of elastic/beats#17539

@jsoriano jsoriano added [zube]: In Review backport Team:Platforms Label for the Integrations - Platforms team labels Jun 12, 2020
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations-platforms (Team:Platforms)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 12, 2020
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #19160 opened]

  • Start Time: 2020-06-12T15:06:51.595+0000

  • Duration: 51 min 37 sec

Test stats 🧪

Test Results
Failed 0
Passed 2795
Skipped 340
Total 3135

@jsoriano jsoriano self-assigned this Jun 12, 2020
@jsoriano jsoriano merged commit 62af1ac into elastic:7.x Jun 15, 2020
@jsoriano jsoriano deleted the backport_19018_7.x branch June 15, 2020 15:21
@zube zube bot removed the [zube]: Done label Oct 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Team:Platforms Label for the Integrations - Platforms team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants