Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat][httpjson] Change append transform to initiate new fields as a slice #25074

Merged
merged 3 commits into from
Apr 14, 2021

Conversation

P1llus
Copy link
Member

@P1llus P1llus commented Apr 14, 2021

What does this PR do?

Currently the append transform for httpjson only creates an array/list/slice once at least 2 values has been appended to a specific field. This creates a situation in which there is no possibilities with any transform, to create a list object that only has a single value.

Why is it important?

Allows users that communicates with API's that requires single value lists as a key/value pair.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 14, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 14, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: P1llus commented: jenkins run tests please

  • Start Time: 2021-04-14T15:06:02.849+0000

  • Duration: 19 min 35 sec

  • Commit: d93b247

Trends 🧪

Image of Build Times

❕ Flaky test report

No test was executed to be analysed.

Copy link
Contributor

@marc-gr marc-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@P1llus
Copy link
Member Author

P1llus commented Apr 14, 2021

jenkins run tests please

@P1llus P1llus merged commit 2b11cf8 into elastic:master Apr 14, 2021
P1llus added a commit to P1llus/beats that referenced this pull request Apr 14, 2021
…s a slice (elastic#25074)

* changing the append processor to create a single value as list, not only if two or more values are added

* removing mistake typo

* add changelog entry

(cherry picked from commit 2b11cf8)
@P1llus P1llus added the v7.12.0 label Apr 14, 2021
v1v added a commit to v1v/beats that referenced this pull request Apr 15, 2021
* upstream/master:
  packer cache support for the 7.x and 7.latestMinor branches (elastic#25091)
  Remove EventFetcher and EventsFetcher interface (elastic#25093)
  Update go-structform to 0.0.8 (elastic#25051)
  Update copy_fields.asciidoc (elastic#25053)
  [elastic-agent] ensure container is backwards compatible (elastic#25092)
  Add --fleet-server-service-token. Rename --fleet-server to --fleet-server-es. (elastic#25083)
  Add cgroup.cpuacct percentages (elastic#25057)
  Add tests for truncated and symlinked files in filestream input (elastic#24425)
  Fix panic when Hearbeat monitor initialization fails twice (elastic#25073)
  [Filebeat][httpjson] Change append transform to initiate new fields as a slice (elastic#25074)
  Osquerybeat: Result values type translation (elastic#25012)
  Update Osquerybeat spec to get it downloading from the correct artifactory path (elastic#25076)
  Fix changelog (elastic#25079)
  Strip Azure EventHub connection string in debug logs (elastic#25066)
  Change googlecloud to gcp in field names (elastic#25038)
  Bump stack version to 7.12.0 for testing (elastic#24957)
  packer-cache: cache the existing docker images on ARM and some more (elastic#25068)
  Disable logstash TestFetch flaky test (elastic#25044)
P1llus added a commit that referenced this pull request Apr 16, 2021
…s a slice (#25074) (#25088)

* changing the append processor to create a single value as list, not only if two or more values are added

* removing mistake typo

* add changelog entry

(cherry picked from commit 2b11cf8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants