Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make filestream input GA #26127

Merged
merged 3 commits into from
Jun 8, 2021
Merged

Make filestream input GA #26127

merged 3 commits into from
Jun 8, 2021

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jun 3, 2021 •
edited
Loading

What does this PR do?

This PR makes filestream GA. It has matured a lot over the last few months, it is time to make it GA.

Why is it important?

It is ready to be adopted by users.

Checklist

- [ ] My code follows the style guidelines of this project
- [ ] I have commented my code, particularly in hard-to-understand areas

  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@kvch kvch added Team:Elastic-Agent Label for the Agent team backport-v7.14.0 Automated backport with mergify labels Jun 3, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 3, 2021
@kvch kvch requested a review from urso June 3, 2021 08:03
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 3, 2021 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: Pull request #26127 updated

  • Start Time: 2021-06-07T15:50:39.454+0000

  • Duration: 104 min 3 sec

  • Commit: 426c13b

Test stats 🧪

Test Results
Failed 0
Passed 14005
Skipped 2292
Total 16297

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 14005
Skipped 2292
Total 16297

@jsoriano
Copy link
Member

jsoriano commented Jun 3, 2021

Is filestream going to completely replace log? Should log docs be updated to recommend this input, or with some deprecation notice?

@kvch
Copy link
Contributor Author

kvch commented Jun 4, 2021 •
edited
Loading

@jsoriano Yes, it is going to replace the log input in the long run. Internally, we already started the adoption of filestream. It is collecting the internal logs of Elastic Agent on 7.x and master.

We already have a list of reasons why it is worth using filestream over log: https://www.elastic.co/guide/en/beats/filebeat/current/filebeat-input-filestream.html#filebeat-input-filestream
However, we are planning to write a blog post as well when the input is released as GA. Also, deprecate log input in the future.

I will create a meta issue, so we can track the progress of this transition. There is already a meta issue: #23822

@kvch kvch mentioned this pull request Jun 4, 2021
Closed
18 tasks
@urso
Copy link

urso commented Jun 7, 2021

Is the input still logging experimental/beta status that we need to remove?

@mergify
Copy link
Contributor

mergify bot commented Jun 7, 2021

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b feature-filebeat-filestream-ga upstream/feature-filebeat-filestream-ga
git merge upstream/master
git push upstream feature-filebeat-filestream-ga

@kvch kvch force-pushed the feature-filebeat-filestream-ga branch from 6601982 to c514821 Compare June 7, 2021 15:42
@kvch
Copy link
Contributor Author

kvch commented Jun 7, 2021

@urso Logging was fine, the default config refered to it as an experimental input. Now it is updated.

@kvch kvch merged commit a3b642b into elastic:master Jun 8, 2021
mergify bot pushed a commit that referenced this pull request Jun 8, 2021
@kvch
Make filestream input GA (#26127)
949ef49 
(cherry picked from commit a3b642b)
@mergify mergify bot mentioned this pull request Jun 8, 2021
Merged
kvch added a commit that referenced this pull request Jun 8, 2021
@mergify @kvch
Make filestream input GA (#26127) (#26202)
8a79a3c 
(cherry picked from commit a3b642b)

Co-authored-by: Noémi Ványi <kvch@users.noreply.github.com>
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 21, 2021
@mdelapenya
Merge branch 'master' into archive-system-tests
30ccbed 
* master: (26 commits)
  Report total and free CPU for vSphere virtual machines (elastic#26167)
  [filebeat] Add preserve_original_event option to o365audit input (elastic#26273)
  Change xml processor names in script processor to match convention (elastic#26263)
  [Oracle] Fixing default values for paths in config template (elastic#26276)
  Add more ECS fields to logs (elastic#25998)
  [Heartbeat] Fix broken invocation of synth package (elastic#26228)
  rename sqs file name (elastic#26227)
  Populate the agent action result if there is no matching action handlers (elastic#26152)
  Add ISO8601 as supported timestamp type (elastic#25564)
  Move Filebeat azure module to GA (elastic#26168)
  Filebeat azure module pipeline fixes and changes (elastic#26148)
  libbeat: monitor version (elastic#26214)
  Add new parser to filestream input: container (elastic#26115)
  [Metricbeat] Add state_statefulset replicas.ready (elastic#26088)
  Disable test processors system test for windows 10 (elastic#26216)
  Fix startup with failing configuration (elastic#26126)
  Remove 32 bits version of Elastic Agent. (elastic#25708)
  Chane fleetmode detection to ony use management.enabled (elastic#26180)
  Make `filestream` input GA (elastic#26127)
  libbeat/idxmgmt/ilm: fix alias creation (elastic#26146)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

Assignees
No one assigned
Labels
backport-v7.14.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@kvch @elasticmachine @jsoriano @urso