Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change fleetmode detection to only use management.enabled #26180

Merged

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Jun 7, 2021

What does this PR do?

Fleetmode detection has been changed ton only use the enabled flag as
fleet is now the only management mode available.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

Fleetmode detection has been changed ton only use the enabled flag as
fleet is now the only management mode available.
@michel-laterman michel-laterman added bug Metricbeat Metricbeat Team:Integrations Label for the Integrations team v7.14.0 Team:Elastic-Agent Label for the Agent team backport-v7.14.0 Automated backport with mergify labels Jun 7, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jun 7, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jun 7, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: michel-laterman commented: /test

  • Start Time: 2021-06-07T18:41:20.160+0000

  • Duration: 63 min 16 sec

  • Commit: b333c14

Test stats 🧪

Test Results
Failed 0
Passed 327
Skipped 9
Total 336

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 327
Skipped 9
Total 336

@michel-laterman
Copy link
Contributor Author

/test

Copy link
Contributor

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I leave the final +1 to @michalpristas.

Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, we're already passing flags correctly

@michel-laterman michel-laterman merged commit 689a746 into elastic:master Jun 8, 2021
@michel-laterman michel-laterman deleted the fleetmode-detection branch June 8, 2021 16:04
mergify bot pushed a commit that referenced this pull request Jun 8, 2021
Fleetmode detection has been changed ton only use the enabled flag as
fleet is now the only management mode available.

(cherry picked from commit 689a746)
michel-laterman added a commit that referenced this pull request Jun 9, 2021
)

Fleetmode detection has been changed ton only use the enabled flag as
fleet is now the only management mode available.

(cherry picked from commit 689a746)

Co-authored-by: Michel Laterman <82832767+michel-laterman@users.noreply.github.com>
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Jun 21, 2021
* master: (26 commits)
  Report total and free CPU for vSphere virtual machines (elastic#26167)
  [filebeat] Add preserve_original_event option to o365audit input (elastic#26273)
  Change xml processor names in script processor to match convention (elastic#26263)
  [Oracle] Fixing default values for paths in config template (elastic#26276)
  Add more ECS fields to logs (elastic#25998)
  [Heartbeat] Fix broken invocation of synth package (elastic#26228)
  rename sqs file name (elastic#26227)
  Populate the agent action result if there is no matching action handlers (elastic#26152)
  Add ISO8601 as supported timestamp type (elastic#25564)
  Move Filebeat azure module to GA (elastic#26168)
  Filebeat azure module pipeline fixes and changes (elastic#26148)
  libbeat: monitor version (elastic#26214)
  Add new parser to filestream input: container (elastic#26115)
  [Metricbeat] Add state_statefulset replicas.ready (elastic#26088)
  Disable test processors system test for windows 10 (elastic#26216)
  Fix startup with failing configuration (elastic#26126)
  Remove 32 bits version of Elastic Agent. (elastic#25708)
  Chane fleetmode detection to ony use management.enabled (elastic#26180)
  Make `filestream` input GA (elastic#26127)
  libbeat/idxmgmt/ilm: fix alias creation (elastic#26146)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify bug Metricbeat Metricbeat Team:Elastic-Agent Label for the Agent team Team:Integrations Label for the Integrations team v7.14.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Apache Status metricset is no longer adjusting fields for fleet mode
4 participants