Report total CPU for vSphere virtual machines #26167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use static CPU entitlement to calculate total and free CPU. Use static memory entitlement instead of configured memory to calculate total and free memory.
botelastic
bot
added
needs_team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
|
Pinging @elastic/integrations (Team:Integrations) |
sayden
reviewed
Jun 10, 2021
sayden
approved these changes
Jun 10, 2021
|
@sayden I have reverted the update of the client library, this is not really needed for this change and I would like to understand what is happening with the linting. I will update it in a separate PR. |
sayden
approved these changes
Jun 14, 2021
jsoriano
commented
Jun 14, 2021
| }, | ||
| } | ||
|
|
||
| totalCPU := vm.Summary.Config.CpuReservation | ||
| if totalCPU > 0 { |
There was a problem hiding this comment.
Issue created to be able to test with the simulator for different cases of reported metrics #26287
mergify bot
pushed a commit
that referenced
this pull request
Jun 14, 2021
Use configured CPU as total, use it to calculate free too. Total and free resources are only reported if they are configured with a total greater than zero. (cherry picked from commit 6c0f28b)
jsoriano
added a commit
that referenced
this pull request
Jun 14, 2021
Use configured CPU as total, use it to calculate free too. Total and free resources are only reported if they are configured with a total greater than zero. (cherry picked from commit 6c0f28b) Co-authored-by: Jaime Soriano Pastor <jaime.soriano@elastic.co>
michalpristas
pushed a commit
to michalpristas/beats
that referenced
this pull request
Jun 17, 2021
Use configured CPU as total, use it to calculate free too. Total and free resources are only reported if they are configured with a total greater than zero.
mdelapenya
added a commit
to mdelapenya/beats
that referenced
this pull request
Jun 21, 2021
* master: (26 commits) Report total and free CPU for vSphere virtual machines (elastic#26167) [filebeat] Add preserve_original_event option to o365audit input (elastic#26273) Change xml processor names in script processor to match convention (elastic#26263) [Oracle] Fixing default values for paths in config template (elastic#26276) Add more ECS fields to logs (elastic#25998) [Heartbeat] Fix broken invocation of synth package (elastic#26228) rename sqs file name (elastic#26227) Populate the agent action result if there is no matching action handlers (elastic#26152) Add ISO8601 as supported timestamp type (elastic#25564) Move Filebeat azure module to GA (elastic#26168) Filebeat azure module pipeline fixes and changes (elastic#26148) libbeat: monitor version (elastic#26214) Add new parser to filestream input: container (elastic#26115) [Metricbeat] Add state_statefulset replicas.ready (elastic#26088) Disable test processors system test for windows 10 (elastic#26216) Fix startup with failing configuration (elastic#26126) Remove 32 bits version of Elastic Agent. (elastic#25708) Chane fleetmode detection to ony use management.enabled (elastic#26180) Make `filestream` input GA (elastic#26127) libbeat/idxmgmt/ilm: fix alias creation (elastic#26146) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Report total and free CPU for vSphere virtual machines. It uses the configured CPU reservation for that.
Update govmomi client library.Why is it important?
This allows to better monitor CPU usage.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues