Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Heartbeat] Move JSON tests from python->go #27816

Merged
merged 2 commits into from
Sep 8, 2021

Conversation

andrewvc
Copy link
Contributor

@andrewvc andrewvc commented Sep 8, 2021

Partial fix for #27815

This moves python tests to go that should have been go in the first place. Much more maintainable this way. Python tests are a better fit for smoke functional tests, not specific monitor functionality.

This should probably make the tests more reliable on windows 2008

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Partial fix for elastic#27815

This moves python tests to go that should have been go in the first
place. Much more maintainable this way.
@andrewvc andrewvc added Heartbeat flaky-test Unstable or unreliable test cases. v7.16.0 labels Sep 8, 2021
@andrewvc andrewvc self-assigned this Sep 8, 2021
@andrewvc andrewvc requested a review from a team as a code owner September 8, 2021 21:27
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2021
@andrewvc andrewvc added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Sep 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Sep 8, 2021
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 8, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-08T21:31:00.622+0000

  • Duration: 67 min 48 sec

  • Commit: 66c7dce

Test stats 🧪

Test Results
Failed 0
Passed 3483
Skipped 80
Total 3563

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 3483
Skipped 80
Total 3563

@andrewvc andrewvc merged commit b04ac92 into elastic:master Sep 8, 2021
@andrewvc andrewvc deleted the fix-json-tests branch September 8, 2021 23:53
@andrewvc
Copy link
Contributor Author

andrewvc commented Sep 8, 2021

@Mergifyio backport 7.x

mergify bot pushed a commit that referenced this pull request Sep 8, 2021
@mergify
Copy link
Contributor

mergify bot commented Sep 8, 2021

Command backport 7.x: success

Backports have been created

andrewvc added a commit that referenced this pull request Sep 9, 2021
(cherry picked from commit b04ac92)

Co-authored-by: Andrew Cholakian <andrew@andrewvc.com>
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Sep 9, 2021
* master: (39 commits)
  [Heartbeat] Move JSON tests from python->go (elastic#27816)
  docs: simplify permissions for Dockerfile COPY (elastic#27754)
  Osquerybeat: Fix osquery logger plugin severy levels mapping (elastic#27789)
  [Filebeat] Update compatibility function to remove processor description on ES < 7.9.0 (elastic#27774)
  warn log entry and no validation failure when both queue_url and buck… (elastic#27612)
  libbeat/cmd/instance: ensure test config file has appropriate permissions (elastic#27178)
  [Heartbeat] Add httpcommon options to ZipURL (elastic#27699)
  Add a header round tripper option to httpcommon (elastic#27509)
  [Elastic Agent] Add validation to ensure certificate paths are absolute. (elastic#27779)
  Rename dashboards according to module.yml files for master (elastic#27749)
  Refactor vagrantfile, add scripts for provisioning with docker/kind (elastic#27726)
  Accept syslog dates with leading 0 (elastic#27775)
  [Filebeat] Add timezone config option to decode_cef and syslog input (elastic#27727)
  [Filebeat] Threatintel compatibility updates (elastic#27323)
  Add support for ephemeral containers in elastic agent dynamic provider (elastic#27707)
  [Filebeat] Integration tests in CI for AWS-S3 input (elastic#27491)
  Fix flakyness of TestFilestreamEmptyLine (elastic#27705)
  [Filebeat] kafka v2 using parsers (elastic#27335)
  Update Kafka version parsing / supported range (elastic#27720)
  Update Sarama to 1.29.1 (elastic#27717)
  ...
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flaky-test Unstable or unreliable test cases. Heartbeat Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants