Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor vagrantfile, add scripts for provisioning with docker/kind #27726

Merged
merged 8 commits into from
Sep 7, 2021

Conversation

fearful-symmetry
Copy link
Contributor

What does this PR do?

This was undertaken as part of my need to test cgroups V2 support on a variety of platforms and docker versions. The current vagrantfile is an aboslute mess, so this is a total refactor that changes how the platforms are listed, moves the provisioning scripts, and adds provisioning options for docker and kind

Ideally, we'd have some testing automation that would run arbitrary tests inside the boxes/containers, but...that falls outside the scope of this, and I have a bad enough habit of making feature-creep PRs.

Why is it important?

This cleans up a very ugly, outdated vagrant file and adds code so we can test docker on various platforms.

Checklist

  • My code follows the style guidelines of this project
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@fearful-symmetry fearful-symmetry added enhancement Team:Integrations Label for the Integrations team labels Sep 2, 2021
@fearful-symmetry fearful-symmetry requested a review from a team September 2, 2021 21:52
@fearful-symmetry fearful-symmetry self-assigned this Sep 2, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/integrations (Team:Integrations)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 2, 2021
@elasticmachine
Copy link
Collaborator

elasticmachine commented Sep 2, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-03T16:29:56.498+0000

  • Duration: 150 min 54 sec

  • Commit: 85fd78a

Test stats 🧪

Test Results
Failed 0
Passed 53827
Skipped 5325
Total 59152

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 53827
Skipped 5325
Total 59152

@fearful-symmetry
Copy link
Contributor Author

/test

Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome refactor. Love to see the provision scripts moved to their own files. Thanks!

@fearful-symmetry fearful-symmetry merged commit 00a3fa3 into elastic:master Sep 7, 2021
mdelapenya added a commit to mdelapenya/beats that referenced this pull request Sep 9, 2021
* master: (39 commits)
  [Heartbeat] Move JSON tests from python->go (elastic#27816)
  docs: simplify permissions for Dockerfile COPY (elastic#27754)
  Osquerybeat: Fix osquery logger plugin severy levels mapping (elastic#27789)
  [Filebeat] Update compatibility function to remove processor description on ES < 7.9.0 (elastic#27774)
  warn log entry and no validation failure when both queue_url and buck… (elastic#27612)
  libbeat/cmd/instance: ensure test config file has appropriate permissions (elastic#27178)
  [Heartbeat] Add httpcommon options to ZipURL (elastic#27699)
  Add a header round tripper option to httpcommon (elastic#27509)
  [Elastic Agent] Add validation to ensure certificate paths are absolute. (elastic#27779)
  Rename dashboards according to module.yml files for master (elastic#27749)
  Refactor vagrantfile, add scripts for provisioning with docker/kind (elastic#27726)
  Accept syslog dates with leading 0 (elastic#27775)
  [Filebeat] Add timezone config option to decode_cef and syslog input (elastic#27727)
  [Filebeat] Threatintel compatibility updates (elastic#27323)
  Add support for ephemeral containers in elastic agent dynamic provider (elastic#27707)
  [Filebeat] Integration tests in CI for AWS-S3 input (elastic#27491)
  Fix flakyness of TestFilestreamEmptyLine (elastic#27705)
  [Filebeat] kafka v2 using parsers (elastic#27335)
  Update Kafka version parsing / supported range (elastic#27720)
  Update Sarama to 1.29.1 (elastic#27717)
  ...
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
…lastic#27726)

* clean up vagrant scripts

* major refactor, partway done

* fix ordering issues

* finish refactor

* fix shell calls

* example docker invocation

* fix example command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Team:Integrations Label for the Integrations team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants