-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor vagrantfile, add scripts for provisioning with docker/kind #27726
Refactor vagrantfile, add scripts for provisioning with docker/kind #27726
Conversation
Pinging @elastic/integrations (Team:Integrations) |
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome refactor. Love to see the provision scripts moved to their own files. Thanks!
* master: (39 commits) [Heartbeat] Move JSON tests from python->go (elastic#27816) docs: simplify permissions for Dockerfile COPY (elastic#27754) Osquerybeat: Fix osquery logger plugin severy levels mapping (elastic#27789) [Filebeat] Update compatibility function to remove processor description on ES < 7.9.0 (elastic#27774) warn log entry and no validation failure when both queue_url and buck… (elastic#27612) libbeat/cmd/instance: ensure test config file has appropriate permissions (elastic#27178) [Heartbeat] Add httpcommon options to ZipURL (elastic#27699) Add a header round tripper option to httpcommon (elastic#27509) [Elastic Agent] Add validation to ensure certificate paths are absolute. (elastic#27779) Rename dashboards according to module.yml files for master (elastic#27749) Refactor vagrantfile, add scripts for provisioning with docker/kind (elastic#27726) Accept syslog dates with leading 0 (elastic#27775) [Filebeat] Add timezone config option to decode_cef and syslog input (elastic#27727) [Filebeat] Threatintel compatibility updates (elastic#27323) Add support for ephemeral containers in elastic agent dynamic provider (elastic#27707) [Filebeat] Integration tests in CI for AWS-S3 input (elastic#27491) Fix flakyness of TestFilestreamEmptyLine (elastic#27705) [Filebeat] kafka v2 using parsers (elastic#27335) Update Kafka version parsing / supported range (elastic#27720) Update Sarama to 1.29.1 (elastic#27717) ...
…lastic#27726) * clean up vagrant scripts * major refactor, partway done * fix ordering issues * finish refactor * fix shell calls * example docker invocation * fix example command
What does this PR do?
This was undertaken as part of my need to test cgroups V2 support on a variety of platforms and docker versions. The current vagrantfile is an aboslute mess, so this is a total refactor that changes how the platforms are listed, moves the provisioning scripts, and adds provisioning options for
docker
andkind
Ideally, we'd have some testing automation that would run arbitrary tests inside the boxes/containers, but...that falls outside the scope of this, and I have a bad enough habit of making feature-creep PRs.
Why is it important?
This cleans up a very ugly, outdated vagrant file and adds code so we can test docker on various platforms.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.