Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix issue where --insecure didn't propogate to Fleet Server E… #27997

Conversation

michalpristas
Copy link
Contributor

What does this PR do?

Reverting commit cbbe8c2a8674630f5bd9ba441c128826bc8269c5 introduced in #27969

The change needs more deeply change and caused failures in our integration pipeline. I'm already working on a change and have a PR soon

Why is it important?

Causes failures in integations pipeline

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added Team:Elastic-Agent Label for the Agent team backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify labels Sep 20, 2021
@michalpristas michalpristas self-assigned this Sep 20, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/agent (Team:Agent)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Sep 20, 2021
@mtojek mtojek self-requested a review September 20, 2021 09:33
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-20T09:10:13.901+0000

  • Duration: 80 min 32 sec

  • Commit: f3c3e4a

Test stats 🧪

Test Results
Failed 0
Passed 7108
Skipped 16
Total 7124

Trends 🧪

Image of Build Times

Image of Tests

💚 Flaky test report

Tests succeeded.

Expand to view the summary

Test stats 🧪

Test Results
Failed 0
Passed 7108
Skipped 16
Total 7124

@michalpristas michalpristas merged commit 88b29b5 into elastic:master Sep 20, 2021
mergify bot pushed a commit that referenced this pull request Sep 20, 2021
…S connection (#27969)" (#27997)

This reverts commit cbbe8c2.

(cherry picked from commit 88b29b5)
mergify bot pushed a commit that referenced this pull request Sep 20, 2021
…S connection (#27969)" (#27997)

This reverts commit cbbe8c2.

(cherry picked from commit 88b29b5)
mergify bot pushed a commit that referenced this pull request Sep 20, 2021
…S connection (#27969)" (#27997)

This reverts commit cbbe8c2.

(cherry picked from commit 88b29b5)
v1v added a commit to v1v/beats that referenced this pull request Sep 20, 2021
* upstream/master: (658 commits)
  Add complete k8s metadata through composable provider (elastic#27691)
  Revert "Fix issue where --insecure didn't propogate to Fleet Server ES connection (elastic#27969)" (elastic#27997)
  Remove deprecated kafka fields (elastic#27938)
  [Filebeat] Add Base64 encoded HMAC & UUID template functions to httpjson input (elastic#27873)
  Improve httpjson template function join (elastic#27996)
  Remove kubernetes.container.image alias (elastic#27898)
  [Elastic Agent] Golden files for program tests (elastic#27862)
  [Elastic Agent] Disable modules.d in metricbeat (elastic#27860)
  libbeat/common/seccomp: provide default policy for linux arm64 (elastic#27955)
  Fix logger statement in aws-s3 input (elastic#27982)
  Fix wrong merge (elastic#27976)
  Fix issue where --insecure didn't propogate to Fleet Server ES connection (elastic#27969)
  Forward-port 7.14.2 changelog to master (elastic#27975)
  [Filebeat] Removing duplicate modules (aliases) Observability (elastic#27919)
  Fix path in vagrant windows script (elastic#27966)
  [Filebeat] Removing duplicate modules (aliases) and Cyberark (elastic#27915)
  No changelog for 8.0.0-alpha2 (elastic#27961)
  Add write access to 'url.value' from 'request.transforms'. (elastic#27937)
  Docker: remove deprecated fields (elastic#27933)
  Filebeat: Make all filesets disabled in default configuration (elastic#27762)
  ...
michalpristas added a commit that referenced this pull request Sep 21, 2021
…S connection (#27969)" (#27997) (#28004)

This reverts commit cbbe8c2.

(cherry picked from commit 88b29b5)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
michalpristas added a commit that referenced this pull request Sep 21, 2021
…S connection (#27969)" (#27997) (#28003)

This reverts commit cbbe8c2.

(cherry picked from commit 88b29b5)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
michalpristas added a commit that referenced this pull request Sep 21, 2021
…S connection (#27969)" (#27997) (#28002)

This reverts commit cbbe8c2.

(cherry picked from commit 88b29b5)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Icedroid pushed a commit to Icedroid/beats that referenced this pull request Nov 1, 2021
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…S connection (elastic#27969)" (elastic#27997) (elastic#28003)

This reverts commit 576be96.

(cherry picked from commit b5ffc57)

Co-authored-by: Michal Pristas <michal.pristas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.14.0 Automated backport with mergify backport-v7.15.0 Automated backport with mergify backport-v7.16.0 Automated backport with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants