-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Add Base64 encoded HMAC & UUID template functions to httpjson input #27873
Conversation
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
This pull request is now in conflicts. Could you fix it? 🙏
|
Hi @legoguy1000 , thanks for your awesome PR's as always! I will discuss this one, as we might not want to use any additional libraries for this, and rather add in the functionality it requires to httpjson itself, it might be that our recent changes we made would work with this actually |
I think the alternative to adding the EdgeGrid Library is to add another HMAC function that returns Base64 encoded signatures instead of Hex. See f746b13 Then do below to implement EdgeGrid and possibly remove the EdgeGrid Module
It appears to work and generates the below headers
|
I think I'm going to also add a UUID template function for the |
52eb2d6
to
ab8af73
Compare
3b36486
to
8d1f1f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 thanks for taking the time to change it with our feedback 😄 !
/test |
1 similar comment
/test |
…son input (#27873) (#28001) * Init commit * Update docs and tests * Add Base64 HMAC * Remove EdgeGrid Library * Add UUID and Base64 HMAC template functions * don't upgrade google/uuid library * Format value_tpl.go Co-authored-by: Marc Guasch <marc.guasch@elastic.co> (cherry picked from commit 942d537) Co-authored-by: Alex Resnick <adr8292@gmail.com>
* upstream/master: (658 commits) Add complete k8s metadata through composable provider (elastic#27691) Revert "Fix issue where --insecure didn't propogate to Fleet Server ES connection (elastic#27969)" (elastic#27997) Remove deprecated kafka fields (elastic#27938) [Filebeat] Add Base64 encoded HMAC & UUID template functions to httpjson input (elastic#27873) Improve httpjson template function join (elastic#27996) Remove kubernetes.container.image alias (elastic#27898) [Elastic Agent] Golden files for program tests (elastic#27862) [Elastic Agent] Disable modules.d in metricbeat (elastic#27860) libbeat/common/seccomp: provide default policy for linux arm64 (elastic#27955) Fix logger statement in aws-s3 input (elastic#27982) Fix wrong merge (elastic#27976) Fix issue where --insecure didn't propogate to Fleet Server ES connection (elastic#27969) Forward-port 7.14.2 changelog to master (elastic#27975) [Filebeat] Removing duplicate modules (aliases) Observability (elastic#27919) Fix path in vagrant windows script (elastic#27966) [Filebeat] Removing duplicate modules (aliases) and Cyberark (elastic#27915) No changelog for 8.0.0-alpha2 (elastic#27961) Add write access to 'url.value' from 'request.transforms'. (elastic#27937) Docker: remove deprecated fields (elastic#27933) Filebeat: Make all filesets disabled in default configuration (elastic#27762) ...
…son input (elastic#27873) * Init commit * Update docs and tests * Add Base64 HMAC * Remove EdgeGrid Library * Add UUID and Base64 HMAC template functions * don't upgrade google/uuid library * Format value_tpl.go Co-authored-by: Marc Guasch <marc.guasch@elastic.co>
What does this PR do?
Add Base64 encoded HMAC & UUID template functions to httpjson input
Why is it important?
In order to create an Akamai Agent integration.
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs