Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Heartbeat] Change size of data on ICMP packet #29948

Merged
merged 2 commits into from
Jan 25, 2022
Merged

[Heartbeat] Change size of data on ICMP packet #29948

merged 2 commits into from
Jan 25, 2022

Conversation

gmarsay
Copy link
Contributor

@gmarsay gmarsay commented Jan 21, 2022

What does this PR do?

Just change size of ICMP packet for Heartbeat. The recommanded size for a valid ICMP packet is 64 byte (with headers)

Why is it important?

Some hosts don't respond with a small ICMP packet

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Compile & configure an ICMP monitor an check packet size with tcpdump

@gmarsay gmarsay requested a review from a team as a code owner January 21, 2022 16:29
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 21, 2022
@mergify
Copy link
Contributor

mergify bot commented Jan 21, 2022

This pull request does not have a backport label. Could you fix it @gmarsay? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Jan 21, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jan 21, 2022 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-01-24T21:50:46.084+0000

  • Duration: 67 min 7 sec

  • Commit: d5f7d2d

Test stats 🧪

Test Results
Failed 0
Passed 3295
Skipped 71
Total 3366

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@mtojek mtojek added the Team:obs-ds-hosted-services Label for the Observability Hosted Services team label Jan 24, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/uptime (Team:Uptime)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 24, 2022
@andrewvc
Copy link
Contributor

Found some documentation of this here: https://www.techtarget.com/searchnetworking/answer/What-are-the-minimum-and-maximum-sizes-of-an-ICMP-packet

@gmarsay
Copy link
Contributor Author

gmarsay commented Jan 24, 2022

backport-v7.16.3

justinkambic
justinkambic approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@justinkambic justinkambic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - smoke tested against main, not seeing any behavior deviation.

@andrewvc
Copy link
Contributor

/test

@andrewvc andrewvc added backport-v8.0.0 Automated backport with mergify backport-7.17 Automated backport to the 7.17 branch with mergify and removed backport-skip Skip notification from the automated backport with mergify labels Jan 25, 2022
@andrewvc andrewvc merged commit da9720c into elastic:master Jan 25, 2022
@andrewvc
Copy link
Contributor

Thanks a bunch for the contribution @gmarsay ! This is a great find!

mergify bot pushed a commit that referenced this pull request Jan 25, 2022
@gmarsay
[Heartbeat] Change size of data on ICMP packet (#29948)
9e28e06 
* [Heartbeat] Change size of data on ICMP packet

* Add CHANGELOG entry.

Co-authored-by: Guillaume Marsay <guillaume.marsay@mediactivegroup.com>
Co-authored-by: Justin Kambic <jk@elastic.co>
(cherry picked from commit da9720c)
@mergify mergify bot mentioned this pull request Jan 25, 2022
Merged
mergify bot pushed a commit that referenced this pull request Jan 25, 2022
@gmarsay
[Heartbeat] Change size of data on ICMP packet (#29948)
10ad24e 
* [Heartbeat] Change size of data on ICMP packet

* Add CHANGELOG entry.

Co-authored-by: Guillaume Marsay <guillaume.marsay@mediactivegroup.com>
Co-authored-by: Justin Kambic <jk@elastic.co>
(cherry picked from commit da9720c)
@mergify mergify bot mentioned this pull request Jan 25, 2022
Merged
@gmarsay gmarsay deleted the patch-icmp-packet-size branch January 25, 2022 08:12
andrewvc pushed a commit that referenced this pull request Jan 25, 2022
@mergify @gmarsay
[Heartbeat] Change size of data on ICMP packet (#29948) (#29979)
6127014 
* [Heartbeat] Change size of data on ICMP packet

* Add CHANGELOG entry.

Co-authored-by: Guillaume Marsay <guillaume.marsay@mediactivegroup.com>
Co-authored-by: Justin Kambic <jk@elastic.co>
(cherry picked from commit da9720c)

Co-authored-by: Guillaume Marsay <gmarsay@gmail.com>
andrewvc pushed a commit that referenced this pull request Jan 25, 2022
@mergify @gmarsay
[Heartbeat] Change size of data on ICMP packet (#29948) (#29978)
2eede7c 
* [Heartbeat] Change size of data on ICMP packet

* Add CHANGELOG entry.

Co-authored-by: Guillaume Marsay <guillaume.marsay@mediactivegroup.com>
Co-authored-by: Justin Kambic <jk@elastic.co>
(cherry picked from commit da9720c)

Co-authored-by: Guillaume Marsay <gmarsay@gmail.com>
v1v added a commit that referenced this pull request Jan 28, 2022
@v1v
Merge remote-tracking branch 'upstream/7.17' into v1v-patch-1
c28c548 
* upstream/7.17: (30 commits)
  [7.17](backport #29966) Add the Elastic product origin header when talking to Elasticsearch or Kibana. (#30000)
  [Heartbeat] Change size of data on ICMP packet (#29948) (#29978)
  Add clarification about enableing dashboard loading (#29985) (#29989)
  Improve aws-s3 gzip file detection to avoid false negatives (#29969) (#29974)
  ci: docker login step for pulling then pushing (#29960) (#29963)
  x-pack/auditbeat/module/system/socket: get full length path and arg from /proc when not available from kprobe (#29410) (#29958)
  [Automation] Update elastic stack version to 7.17.0-ab4975a2 for testing (#29956)
  [Automation] Update elastic stack version to 7.17.0-1bd58b32 for testing (#29938)
  [7.17](backport #29913) [Metricbeat] gcp.gke: fix overview dashboard (#29914)
  [7.17](backport #29605) Fix annotation enrichment (#29834)
  [Automation] Update elastic stack version to 7.17.0-e1efbe3a for testing (#29922)
  [Automation] Update elastic stack version to 7.17.0-68da5d12 for testing (#29904)
  [7.17][Heartbeat] Defer monitor / ICMP errors to monitor runtime / ES (backport #29413) (#29896)
  Merge pull request from GHSA-rj4h-hqvq-cc6q
  [7.17](backport #29681) Change docker image from CentOS 7 to Ubuntu 20.04 (#29817)
  Fix YAML indentation in `parsers` examples (#29663) (#29894)
  [Automation] Update elastic stack version to 7.17.0-079761a0 for testing (#29864)
  Fix Filebeat dissect processor field tokenization in documentation (#29680) (#29883)
  Enable require_alias for Bulk requests for all actions when target is a write alias (#29879)
  Update Index template loading guide to use the correct endpoint (#29869) (#29877)
  ...
yashtewari pushed a commit to build-security/beats that referenced this pull request Jan 30, 2022
@gmarsay @justinkambic @yashtewari
[Heartbeat] Change size of data on ICMP packet (elastic#29948)
ec99aa3 
* [Heartbeat] Change size of data on ICMP packet

* Add CHANGELOG entry.

Co-authored-by: Guillaume Marsay <guillaume.marsay@mediactivegroup.com>
Co-authored-by: Justin Kambic <jk@elastic.co>
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
@v1v
Merge remote-tracking branch 'upstream/7.17' into v1v-patch-1
82291ab 
* upstream/7.17: (30 commits)
  [7.17](backport elastic#29966) Add the Elastic product origin header when talking to Elasticsearch or Kibana. (elastic#30000)
  [Heartbeat] Change size of data on ICMP packet (elastic#29948) (elastic#29978)
  Add clarification about enableing dashboard loading (elastic#29985) (elastic#29989)
  Improve aws-s3 gzip file detection to avoid false negatives (elastic#29969) (elastic#29974)
  ci: docker login step for pulling then pushing (elastic#29960) (elastic#29963)
  x-pack/auditbeat/module/system/socket: get full length path and arg from /proc when not available from kprobe (elastic#29410) (elastic#29958)
  [Automation] Update elastic stack version to 7.17.0-ab4975a2 for testing (elastic#29956)
  [Automation] Update elastic stack version to 7.17.0-1bd58b32 for testing (elastic#29938)
  [7.17](backport elastic#29913) [Metricbeat] gcp.gke: fix overview dashboard (elastic#29914)
  [7.17](backport elastic#29605) Fix annotation enrichment (elastic#29834)
  [Automation] Update elastic stack version to 7.17.0-e1efbe3a for testing (elastic#29922)
  [Automation] Update elastic stack version to 7.17.0-68da5d12 for testing (elastic#29904)
  [7.17][Heartbeat] Defer monitor / ICMP errors to monitor runtime / ES (backport elastic#29413) (elastic#29896)
  Merge pull request from GHSA-rj4h-hqvq-cc6q
  [7.17](backport elastic#29681) Change docker image from CentOS 7 to Ubuntu 20.04 (elastic#29817)
  Fix YAML indentation in `parsers` examples (elastic#29663) (elastic#29894)
  [Automation] Update elastic stack version to 7.17.0-079761a0 for testing (elastic#29864)
  Fix Filebeat dissect processor field tokenization in documentation (elastic#29680) (elastic#29883)
  Enable require_alias for Bulk requests for all actions when target is a write alias (elastic#29879)
  Update Index template loading guide to use the correct endpoint (elastic#29869) (elastic#29877)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinkambic justinkambic justinkambic approved these changes

Assignees
No one assigned
Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.0.0 Automated backport with mergify Team:obs-ds-hosted-services Label for the Observability Hosted Services team v7.17.0 v8.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gmarsay @elasticmachine @andrewvc @justinkambic @mtojek