[WIP] Ignores ErrInputNotFinished when updating config #31928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignores `common.InputNotFinished` when running undre Elastic-Agent and updating configuration. A few refactorings were needed: * "github.com/hashicorp/go-multierror" was replaced by "github.com/joeshaw/multierror" that is already used by other parts of Beats. This makes the error wrapping more consistent * common.InputNotFinished implements the `Is` method, making it compatible with `errors.Is`.
botelastic
bot
added
the
needs_team
💔 Build Failed
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
belimawr
added
the
Team:Elastic-Agent-Data-Plane
botelastic
bot
removed
the
needs_team
kvch
reviewed
Jun 15, 2022
| @@ -85,7 +85,7 @@ func (r *RunnerList) Reload(configs []*reload.ConfigWithMeta) error { | |||
| for hash, runner := range stopList { | |||
| r.logger.Debugf("Stopping runner: %s", runner) | |||
| delete(r.runners, hash) | |||
| go runner.Stop() | |||
| runner.Stop() // we need to wait this to finish before starting new inputs | |||
There was a problem hiding this comment.
Do we? It did not fix the problem we had, so I do not want to change this to be blocking. Why "fix" something that is not broken?
There was a problem hiding this comment.
Indeed.
This PR still a draft of a draft, it still needs cleaning up. If we decide to keep working on that I'll keep it async.
|
076e702 contains a HUGE amount of debug code, it's quite messy. If I keep working on this PR, I'll clean up everything before requesting a review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT REVIEW
I added a bunch of debug and experiment code here just to to lose it for the time being.
Current status
I'm creating this PR very early to see if any integration test will break.
Ignores
common.InputNotFinishedwhen running undre Elastic-Agent andupdating configuration.
A few refactorings were needed:
"github.com/joeshaw/multierror" that is already used by other parts of
Beats. This makes the error wrapping more consistent
Ismethod, making itcompatible with
errors.Is.What does this PR do?
Why is it important?
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs