-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify generator #3452
Unify generator #3452
Conversation
69d26a6
to
a35ddc9
Compare
* Use one script create generic beat or metricbeat * Rename `generate` directory to `template` * Share most parts of the testing makefile * Update docs to new logic * Update travis build file
a35ddc9
to
e59d1d6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only a small comment about the name of the directory template
, not to be confused with something else.
@ruflin What about moving the |
@monicasarbu I actually just did the opposite step with this PR :-) The reason I put it under script (besides that it is a script) is that I think it is unlikely that we will change the name of the folder or move the folder in the near future. This means we will not break the generator again. All the other directories (be it template or generator or xyz) do not matter to the user as it we only have to adjust it inside the script. So I think we should keep |
@ruflin That's a good point. I would say to keep the script in the |
@monicasarbu renamed |
Waiting for green |
generate
directory totemplate
(UPDATE:generator
)