Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace *regexp.Regexp with match.Matcher #3469

Merged
merged 6 commits into from Jan 27, 2017

Conversation

@urso
Copy link
Collaborator

commented Jan 25, 2017

replace regular expressions used for matching a string only with match.Matcher in all beats.

  • libbeat processor changes:
    • unify handling of strings/regexp. Both handle string, []string and try to convert to string if input is no string
    • use match.Match for contains and regexp conditionals

@urso urso added review discuss in progress and removed review labels Jan 25, 2017

@urso urso force-pushed the urso:enh/use-string-matcher branch from 26f9154 to 6b71a78 Jan 26, 2017

@urso urso added review and removed discuss in progress labels Jan 26, 2017

@andrewkroh andrewkroh merged commit 3fce440 into elastic:master Jan 27, 2017

4 checks passed

CLA Commit author is a member of Elasticsearch
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Build finished.
Details

@urso urso deleted the urso:enh/use-string-matcher branch Feb 19, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.