-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
x-pack/filebeat/input/awss3[integration test]Test integration tests on localstack #35727
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
4536076
to
887bdf0
Compare
887bdf0
to
4eb901c
Compare
4eb901c
to
0adb357
Compare
baf3198
to
4d81d68
Compare
550ca31
to
d17c60b
Compare
d17c60b
to
601ae90
Compare
Pinging @elastic/security-external-integrations (Team:Security-External Integrations) |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pierrehilbert since you tried out Terraform recently, you might want to have a look at this.
LGTM, only minor formatting suggestions from me.
Depends on #36101 |
This pull request is now in conflicts. Could you fix it? 🙏
|
26dff85
to
207e80d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A minor nitpick for some indentation but looks good to me. Thanks for the contribution!
…n localstack (elastic#35727) * Test integration tests on localstack * Add localstack container in CI * fix panic in SQS input metrics * Add documentation * Fix PR comments
What does this PR do?
This PR provides support in
awss3
input_integration_test
to test input against an emulated cloud environment Localstack.This PR adds an example integration test to test
SQS notifications
when an Object is PUT in S3 where S3 and SQS are provisioned in Localstack.This PR adds support to run the test in CI too including
cleanup
in both positive and negative scenarios.Why is it important?
This PR provides a lot of flexibility for developers to test
awss3
input against emulated cloud env instead of waiting to run on real AWS resources , which saves both time and money.Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
docker-compose -f .ci/jobs/docker-compose.yml up -d
x-pack/filebeat/input/awss3
go test -tags aws,integration -run TestInputRunSQSOnLocalstack -v
Related issues
Logs