Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more dimensions to allowedDimensions for azure storage account to… #36331

Merged
merged 3 commits into from
Aug 16, 2023

Conversation

ritalwar
Copy link
Contributor

  • Enhancement

Proposed commit message

Enabling TSDB functionality requires designating all dimension fields as "true" to avoid any data or event loss. The existing code for Azure storage account presently allows only two dimensions: ApiName and ResponseType. This PR aims to add the additional dimensions("GeoType", "Authentication", "BlobType", "Tier", "FileShare"), which can subsequently be set as "true" in integrations, to enable TSDB for azure storage account.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

Related issues

Screenshots

image
image

@ritalwar ritalwar requested a review from a team as a code owner August 16, 2023 05:48
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Aug 16, 2023
@mergify
Copy link
Contributor

mergify bot commented Aug 16, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ritalwar? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Aug 16, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-08-16T05:56:02.552+0000

  • Duration: 54 min 7 sec

Test stats 🧪

Test Results
Failed 0
Passed 1478
Skipped 96
Total 1574

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ritalwar ritalwar added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Aug 16, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Aug 16, 2023
Copy link

@milan-elastic milan-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tetianakravchenko tetianakravchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
All dimensions linted in Microsoft.ClassicStorage/storageAccounts, blobServices, fileServices, queueServices and tableServices are covered

@ritalwar ritalwar merged commit 138e623 into elastic:main Aug 16, 2023
8 checks passed
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
elastic#36331)

* Add more dimensions to allowedDimensions for azure storage account to support tsdb enablement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Azure storage account dataset by adding missing dimension fields
5 participants