Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[filebeat][azure-blob-storage] - Cleaned up documentation errors & fixed a minor bug. #36714

Merged
merged 2 commits into from
Oct 2, 2023
Merged

[filebeat][azure-blob-storage] - Cleaned up documentation errors & fixed a minor bug. #36714

merged 2 commits into from
Oct 2, 2023

Conversation

ShourieG
Copy link
Contributor

@ShourieG ShourieG commented Oct 2, 2023 •
edited
Loading

Type of change

  • Bug
  • Docs

Proposed commit message

There was a minor logical error and a documentation error for the PR: #36690,
which was discovered after the merge. This PR aims to fix those.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
    - [ ] I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@ShourieG ShourieG requested a review from a team as a code owner October 2, 2023 07:56
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Oct 2, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @ShourieG? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2023
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label 8.11-candidate labels Oct 2, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2023
@ShourieG ShourieG added Filebeat Filebeat needs_team Indicates that the issue/PR needs a Team:* label labels Oct 2, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2023
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label bugfix labels Oct 2, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2023
@ShourieG ShourieG added needs_team Indicates that the issue/PR needs a Team:* label backport-skip Skip notification from the automated backport with mergify labels Oct 2, 2023
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Oct 2, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Oct 2, 2023 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 76 min 52 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@ShourieG
Copy link
Contributor Author

ShourieG commented Oct 2, 2023

@bhapas if all else looks good, could you approve ?

@ShourieG ShourieG enabled auto-merge (squash) October 2, 2023 10:30
bhapas
bhapas approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@bhapas bhapas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM..

@ShourieG tested the change manually

@ShourieG ShourieG merged commit 050cbf5 into elastic:main Oct 2, 2023
8 checks passed
@ShourieG ShourieG deleted the abs/fix_errors branch October 2, 2023 10:36
@chaolihf chaolihf mentioned this pull request Oct 2, 2023
Merged
6 tasks
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
@ShourieG @Scholar-Li
[filebeat][azure-blob-storage] - Cleaned up documentation errors & fi…
9d0b0c1 
…xed a minor bug. (elastic#36714)

* fixed a logical bug, updated docs

* updated changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhapas bhapas bhapas approved these changes

Assignees

@ShourieG ShourieG

Labels
8.11-candidate backport-skip Skip notification from the automated backport with mergify bugfix Filebeat Filebeat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ShourieG @elasticmachine @bhapas