Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.17](backport #39713) [x-pack/filebeat/cel] increase timeout in unit-tests #39745

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 27, 2024

Proposed commit message

As captured here there have been seldom occurrences that unit-tests of cel input come up with failures. After a quick analysis and a discussion with @efd6, we both agree that the context timeout in the cel unit-tests can end up being too tight, especially for machines under workload, and hence this PR increases it. Note that this timeout increment shouldn't affect the duration of the passing unit-tests as the context is cancelled as soon as the defined criteria are met.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

N/A

How to test this PR locally

Related issues

Use cases

N/A

Screenshots

N/A

Logs

N/A


This is an automatic backport of pull request #39713 done by Mergify.

(cherry picked from commit f3bd8f2)

# Conflicts:
#	x-pack/filebeat/input/cel/input_test.go
@mergify mergify bot requested a review from a team as a code owner May 27, 2024 14:44
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels May 27, 2024
@mergify mergify bot requested review from AndersonQ and faec and removed request for a team May 27, 2024 14:44
Copy link
Contributor Author

mergify bot commented May 27, 2024

Cherry-pick of f3bd8f2 has failed:

On branch mergify/bp/7.17/pr-39713
Your branch is up to date with 'origin/7.17'.

You are currently cherry-picking commit f3bd8f2e79.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add/rm <file>..." as appropriate to mark resolution)
	deleted by us:   x-pack/filebeat/input/cel/input_test.go

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 27, 2024
@botelastic
Copy link

botelastic bot commented May 27, 2024

This pull request doesn't have a Team:<team> label.

@pkoutsovasilis
Copy link
Contributor

closing as this CEL test is not part of 7.17

@mergify mergify bot deleted the mergify/bp/7.17/pr-39713 branch May 27, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant