Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[x-pack/filebeat/cel] increase timeout in unit-tests #39713

Merged
merged 1 commit into from
May 27, 2024
Merged

[x-pack/filebeat/cel] increase timeout in unit-tests #39713

merged 1 commit into from
May 27, 2024

Conversation

pkoutsovasilis
Copy link
Contributor

Proposed commit message

As captured here there have been seldom occurrences that unit-tests of cel input come up with failures. After a quick analysis and a discussion with @efd6, we both agree that the context timeout in the cel unit-tests can end up being too tight, especially for machines under workload, and hence this PR increases it. Note that this timeout increment shouldn't affect the duration of the passing unit-tests as the context is cancelled as soon as the defined criteria are met.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

N/A

How to test this PR locally

Related issues

Use cases

N/A

Screenshots

N/A

Logs

N/A

@pkoutsovasilis pkoutsovasilis requested a review from a team as a code owner May 24, 2024 08:47
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 24, 2024
@pkoutsovasilis pkoutsovasilis added flaky-test Unstable or unreliable test cases. Team:Service-Integrations Label for the Service Integrations team labels May 24, 2024
@pkoutsovasilis pkoutsovasilis self-assigned this May 24, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 24, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 24, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @pkoutsovasilis? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pkoutsovasilis
Copy link
Contributor Author

@dliappis do you know where this should be backported?

@dliappis
Copy link
Contributor

@dliappis do you know where this should be backported?

I'd say 8.14, 8.13 for sure and 7.17 as well, if the test exists there.

@pkoutsovasilis pkoutsovasilis added backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify labels May 27, 2024
@pkoutsovasilis pkoutsovasilis merged commit f3bd8f2 into elastic:main May 27, 2024
15 of 18 checks passed
@pkoutsovasilis pkoutsovasilis deleted the pkoutsovasilis/cel_tests_increase_timeout branch May 27, 2024 14:42
mergify bot pushed a commit that referenced this pull request May 27, 2024
@pkoutsovasilis @mergify
fix: increase ctx timeout in cel unit-tests (#39713)
ef525a1 
(cherry picked from commit f3bd8f2)

# Conflicts:
#	x-pack/filebeat/input/cel/input_test.go
mergify bot pushed a commit that referenced this pull request May 27, 2024
@pkoutsovasilis @mergify
fix: increase ctx timeout in cel unit-tests (#39713)
05fe6c6 
(cherry picked from commit f3bd8f2)
This was referenced May 27, 2024
Closed
Merged
mergify bot pushed a commit that referenced this pull request May 27, 2024
@pkoutsovasilis @mergify
fix: increase ctx timeout in cel unit-tests (#39713)
d9cae99 
(cherry picked from commit f3bd8f2)
@mergify mergify bot mentioned this pull request May 27, 2024
Merged
6 tasks
@pkoutsovasilis pkoutsovasilis removed the backport-v7.17.0 Automated backport with mergify label May 27, 2024
pkoutsovasilis added a commit that referenced this pull request May 27, 2024
@mergify @pkoutsovasilis
fix: increase ctx timeout in cel unit-tests (#39713) (#39747)
497f7ed 
(cherry picked from commit f3bd8f2)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
pkoutsovasilis added a commit that referenced this pull request May 27, 2024
@mergify @pkoutsovasilis
fix: increase ctx timeout in cel unit-tests (#39713) (#39746)
08f2883 
(cherry picked from commit f3bd8f2)

Co-authored-by: Panos Koutsovasilis <panos.koutsovasilis@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efd6 efd6 efd6 approved these changes

Assignees

@pkoutsovasilis pkoutsovasilis

Labels
backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify flaky-test Unstable or unreliable test cases. Team:Service-Integrations Label for the Service Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

x-pack/filebeat/input/cel TestInput/retry_failure on Windows
3 participants
@pkoutsovasilis @dliappis @efd6