Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GCP: fix config period value when the given value is below the minimum allowed period. #40020

Merged
merged 5 commits into from
Jul 3, 2024

Conversation

Linu-Elias
Copy link
Contributor

Proposed commit message

Currently GCP module errors when a period less than a minimum given by GCP APIs is specified. It should not produce an error, correct the value to the minimum and produce a warning log message.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

  • [ ]

@Linu-Elias Linu-Elias requested review from a team as code owners June 26, 2024 11:49
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 26, 2024
Copy link
Contributor

mergify bot commented Jun 26, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @Linu-Elias? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@gpop63 gpop63 added the Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team label Jun 26, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jun 26, 2024
CHANGELOG.next.asciidoc Outdated Show resolved Hide resolved
x-pack/metricbeat/module/gcp/metrics/metricset.go Outdated Show resolved Hide resolved
@Linu-Elias Linu-Elias changed the title GCP: Period Fix GCP: set config period to the default (60s) when the value is below the minimum allowed period. Jun 26, 2024
@Linu-Elias Linu-Elias changed the title GCP: set config period to the default (60s) when the value is below the minimum allowed period. GCP: set config period to the default when the value is below the minimum allowed period. Jun 26, 2024
@Linu-Elias Linu-Elias changed the title GCP: set config period to the default when the value is below the minimum allowed period. GCP: fix config period value when the given value is below the minimum allowed period. Jun 26, 2024
@ishleenk17 ishleenk17 merged commit 7f79f0a into elastic:main Jul 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metricbeat] GCP module should not error when period is less than minimum
4 participants