Add support for index to fields.yml #4853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `index: false` for a field was not possible so far. This adds this possibility. For more details in `index` see: https://www.elastic.co/guide/en/elasticsearch/reference/5.5/mapping-index.html Additional changes: * `enable` and `dynamic` are only available for objects. The functionality was move to object. https://www.elastic.co/guide/en/elasticsearch/reference/5.5/enabled.html * Add support for `enable` and `index` to the docs script so it is visible in the docs which fields are indexed and which ones not
simitt
reviewed
Aug 9, 2017
|
|
||
| if f.Dynamic.value != nil { | ||
| property["dynamic"] = f.Dynamic.value | ||
| if f.Index != nil { |
There was a problem hiding this comment.
Why do you treat f.Index as default property but not f.Enabled?
There was a problem hiding this comment.
As enable is only available for objects, so I moved it to objects.
|
jenkins, test it |
1 similar comment
|
jenkins, test it |
ruflin
added a commit
to ruflin/beats
that referenced
this pull request
Aug 14, 2017
With elastic#4853 in fields.yml fields can be marked as `enable: false` or `index: false`. This should also have an affect on the index pattern. Objects which are not enabled will be skipped in the index pattern and fields which are not indexed all settings are set to false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting
index: falsefor a field was not possible so far. This adds this possibility. For more details inindexsee: https://www.elastic.co/guide/en/elasticsearch/reference/5.5/mapping-index.htmlAdditional changes:
enableanddynamicare only available for objects. The functionality was move to object. https://www.elastic.co/guide/en/elasticsearch/reference/5.5/enabled.htmlenableandindexto the docs script so it is visible in the docs which fields are indexed and which ones not